From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E758EE49A3 for ; Tue, 22 Aug 2023 04:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232509AbjHVEC3 (ORCPT ); Tue, 22 Aug 2023 00:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjHVEC2 (ORCPT ); Tue, 22 Aug 2023 00:02:28 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDE46187; Mon, 21 Aug 2023 21:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692676946; x=1724212946; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=O3htJ+kFLf2fHtcw2MsI+po3ccJ4ybveNo01UE0BG8w=; b=RLvpi66+/bJVvPfZTacILFBGYD+BXQEQbSshYkFXqo+pGKwt+EB5gJ/V Z59bIWLRXLPY9UhTl5o5Q/LrtPziCQNffvhciDqb0z+kOZB02OMW6lKXI YqUx37ZxOpIEO4xup8w/CByEIZGQ0P590Cytw6QRvM8L36Ps7BGy/19i/ 4dyaQEsStgu8RhrYGYx6Kemc7kCJig5JPPAPcMzyx8ugdyifn3x201yec EdhZM2IVvfi8zuVXHmaOXE1alebibqo2kMwjVzczP9fw4malu8HiQQFGZ avT3+6RKku6Atctmk2EBiGrZbV9miWWheSp5hB382SnScNSoSE40mqw/X Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="404772012" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="404772012" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 21:02:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="850442004" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="850442004" Received: from lkp-server02.sh.intel.com (HELO 6809aa828f2a) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 21 Aug 2023 21:02:24 -0700 Received: from kbuild by 6809aa828f2a with local (Exim 4.96) (envelope-from ) id 1qYIb1-0001KI-2U; Tue, 22 Aug 2023 04:02:23 +0000 Date: Tue, 22 Aug 2023 12:00:25 +0800 From: kernel test robot To: "Masami Hiramatsu (Google)" , Steven Rostedt Cc: oe-kbuild-all@lists.linux.dev, Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: Fix to avoid wakeup loop in splice read of per-cpu buffer Message-ID: <202308221154.hil5JaxI-lkp@intel.com> References: <169262755804.106231.8245792908363050528.stgit@devnote2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <169262755804.106231.8245792908363050528.stgit@devnote2> Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org Hi Masami, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.5-rc7 next-20230821] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Masami-Hiramatsu-Google/tracing-Fix-to-avoid-wakeup-loop-in-splice-read-of-per-cpu-buffer/20230821-222307 base: linus/master patch link: https://lore.kernel.org/r/169262755804.106231.8245792908363050528.stgit%40devnote2 patch subject: [PATCH] tracing: Fix to avoid wakeup loop in splice read of per-cpu buffer config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20230822/202308221154.hil5JaxI-lkp@intel.com/config) compiler: mips-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230822/202308221154.hil5JaxI-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308221154.hil5JaxI-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from arch/mips/include/asm/div64.h:89, from include/linux/math.h:6, from include/linux/math64.h:6, from include/linux/time64.h:5, from include/linux/restart_block.h:10, from include/linux/thread_info.h:14, from include/asm-generic/preempt.h:5, from ./arch/mips/include/generated/asm/preempt.h:1, from include/linux/preempt.h:79, from include/linux/spinlock.h:56, from include/linux/mmzone.h:8, from include/linux/gfp.h:7, from include/linux/mm.h:7, from include/linux/ring_buffer.h:5, from kernel/trace/trace.c:15: kernel/trace/trace.c: In function 'tracing_buffers_splice_read': >> include/asm-generic/div64.h:222:35: warning: comparison of distinct pointer types lacks a cast 222 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ | ^~ kernel/trace/trace.c:8481:25: note: in expansion of macro 'do_div' 8481 | do_div(full, nr_pages); | ^~~~~~ In file included from arch/mips/include/asm/bug.h:5, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:6: >> include/asm-generic/div64.h:234:32: warning: right shift count >= width of type [-Wshift-count-overflow] 234 | } else if (likely(((n) >> 32) == 0)) { \ | ^~ include/linux/compiler.h:76:45: note: in definition of macro 'likely' 76 | # define likely(x) __builtin_expect(!!(x), 1) | ^ kernel/trace/trace.c:8481:25: note: in expansion of macro 'do_div' 8481 | do_div(full, nr_pages); | ^~~~~~ vim +222 include/asm-generic/div64.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 215 ^1da177e4c3f41 Linus Torvalds 2005-04-16 216 /* The unnecessary pointer compare is there ^1da177e4c3f41 Linus Torvalds 2005-04-16 217 * to check for type safety (n must be 64bit) ^1da177e4c3f41 Linus Torvalds 2005-04-16 218 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 219 # define do_div(n,base) ({ \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 220 uint32_t __base = (base); \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 221 uint32_t __rem; \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 @222 (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ 911918aa7ef6f8 Nicolas Pitre 2015-11-02 223 if (__builtin_constant_p(__base) && \ 911918aa7ef6f8 Nicolas Pitre 2015-11-02 224 is_power_of_2(__base)) { \ 911918aa7ef6f8 Nicolas Pitre 2015-11-02 225 __rem = (n) & (__base - 1); \ 911918aa7ef6f8 Nicolas Pitre 2015-11-02 226 (n) >>= ilog2(__base); \ c747ce4706190e Geert Uytterhoeven 2021-08-11 227 } else if (__builtin_constant_p(__base) && \ 461a5e51060c93 Nicolas Pitre 2015-10-30 228 __base != 0) { \ 461a5e51060c93 Nicolas Pitre 2015-10-30 229 uint32_t __res_lo, __n_lo = (n); \ 461a5e51060c93 Nicolas Pitre 2015-10-30 230 (n) = __div64_const32(n, __base); \ 461a5e51060c93 Nicolas Pitre 2015-10-30 231 /* the remainder can be computed with 32-bit regs */ \ 461a5e51060c93 Nicolas Pitre 2015-10-30 232 __res_lo = (n); \ 461a5e51060c93 Nicolas Pitre 2015-10-30 233 __rem = __n_lo - __res_lo * __base; \ 911918aa7ef6f8 Nicolas Pitre 2015-11-02 @234 } else if (likely(((n) >> 32) == 0)) { \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 235 __rem = (uint32_t)(n) % __base; \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 236 (n) = (uint32_t)(n) / __base; \ c747ce4706190e Geert Uytterhoeven 2021-08-11 237 } else { \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 238 __rem = __div64_32(&(n), __base); \ c747ce4706190e Geert Uytterhoeven 2021-08-11 239 } \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 240 __rem; \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 241 }) ^1da177e4c3f41 Linus Torvalds 2005-04-16 242 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki