From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B804BEE49A3 for ; Tue, 22 Aug 2023 12:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235816AbjHVMsQ (ORCPT ); Tue, 22 Aug 2023 08:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231969AbjHVMsP (ORCPT ); Tue, 22 Aug 2023 08:48:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10C15196; Tue, 22 Aug 2023 05:48:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9741461B6B; Tue, 22 Aug 2023 12:48:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CA18C433C8; Tue, 22 Aug 2023 12:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692708492; bh=hTVm/b0N8NguFJ5x6CgSVQ+Z18ArJtFry/1eW4AWKrU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hLJ2E3dysk7ZsDh75r6OYztZG5XSye2OViteqw/5Ede7U3dhUMPprgvS3hOO8pupE Vs7Q9gBvYiW9ebP60Bh1c989QBY2zKpIvbhNRG89SkyEeOgxhHklhOYrTzH1JREQ1r eyeRSzvSc3Eb151FEYULcCdQ4m2JymyUTehzTA7wtownj0q9Saggckz+9aJWCU8Q4k wQNq6PUtrBxLFo9KX1upBdKJ/ADkCWakrN39UMrY7oS/GG0neSSizXXpRJC7VNof1m jTF7ztfJNQOLnYg6R0OQe21aQorEHAzKBKCMKoCWcLAgkpVlXa/edxYGjfZT/z0k6r +/89qv+sClTYw== Date: Tue, 22 Aug 2023 21:48:08 +0900 From: Masami Hiramatsu (Google) To: Steven Rostedt Cc: LKML , Linux trace kernel , Masami Hiramatsu , Mark Rutland , "Matthew Wilcox (Oracle)" Subject: Re: [PATCH] tracefs: Remove kerneldoc from struct eventfs_file Message-Id: <20230822214808.6da2059746218d93fa6bfe0e@kernel.org> In-Reply-To: <20230822053313.77aa3397@rorschach.local.home> References: <20230822053313.77aa3397@rorschach.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-kernel@vger.kernel.org On Tue, 22 Aug 2023 05:33:13 -0400 Steven Rostedt wrote: > From d0d094090c093499380049c413b8f1c5b995ff52 Mon Sep 17 00:00:00 2001 > From: "Steven Rostedt (Google)" > Date: Tue, 22 Aug 2023 05:29:22 -0400 > Subject: [PATCH] tracefs: Remove kerneldoc from struct eventfs_file > > The struct eventfs_file is a local structure and should not be parsed by > kernel doc. It also does not fully follow the kerneldoc format and is > causing kerneldoc to spit out errors. Replace the /** to /* so that > kerneldoc no longer processes this structure. > > Also format the comments of the delete union of the structure to be a bit > better. Looks good to me. Reviewed-by: Masami Hiramatsu (Google) Thanks, > > Link: https://lore.kernel.org/linux-trace-kernel/20230818201414.2729745-1-willy@infradead.org/ > > Reported-by: Matthew Wilcox (Oracle) > Signed-off-by: Steven Rostedt (Google) > --- > fs/tracefs/event_inode.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c > index da8d2e73cc47..237c6f370ad9 100644 > --- a/fs/tracefs/event_inode.c > +++ b/fs/tracefs/event_inode.c > @@ -27,7 +27,7 @@ struct eventfs_inode { > struct list_head e_top_files; > }; > > -/** > +/* > * struct eventfs_file - hold the properties of the eventfs files and > * directories. > * @name: the name of the file or directory to create > @@ -48,10 +48,16 @@ struct eventfs_file { > struct eventfs_inode *ei; > const struct file_operations *fop; > const struct inode_operations *iop; > + /* > + * Union - used for deletion > + * @del_list: list of eventfs_file to delete > + * @rcu: eventfs_file to delete in RCU > + * @is_freed: node is freed if one of the above is set > + */ > union { > - struct list_head del_list; /* list of eventfs_file to delete */ > - struct rcu_head rcu; /* eventfs_file to delete */ > - unsigned long is_freed; /* Freed if one of the above is set */ > + struct list_head del_list; > + struct rcu_head rcu; > + unsigned long is_freed; > }; > void *data; > umode_t mode; > -- > 2.40.1 > -- Masami Hiramatsu (Google)