From: Steven Rostedt <rostedt@goodmis.org>
To: Zheng Yejian <zhengyejian1@huawei.com>
Cc: Brian Foster <bfoster@redhat.com>,
<linux-trace-kernel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: zero the pipe cpumask on alloc to avoid spurious -EBUSY
Date: Thu, 31 Aug 2023 16:33:31 -0400 [thread overview]
Message-ID: <20230831163331.6c90c963@rorschach.local.home> (raw)
In-Reply-To: <26f8fb43-6ea8-edc2-381d-3600fce261af@huawei.com>
On Thu, 31 Aug 2023 21:51:18 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:
> > Hi,
> >
> > I ran into this problem just recently on one of my test VMs immediately
> > after updating to a v6.5 base. A revert of the aforementioned commit
> > addressed the problem. I'm not terribly familiar with the tracing code,
> > but on further inspection I noticed the cpumask doesn't appear to be
> > initialized anywhere. I suppose this could alternatively do a
> > cpumask_clear() or whatever after allocation, but either way this
> > addresses the problem for me.
>
> Yes, pipe_cpumask must be initialized.
Can I add a Reviewed-by tag from you?
>
> >
> > Please CC on replies as I'm not subscribed to the list. Thanks.
That's the default with Linux kernel lists.
-- Steve
next prev parent reply other threads:[~2023-08-31 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 12:55 [PATCH] tracing: zero the pipe cpumask on alloc to avoid spurious -EBUSY Brian Foster
2023-08-31 13:51 ` Zheng Yejian
2023-08-31 20:33 ` Steven Rostedt [this message]
2023-09-01 1:34 ` Zheng Yejian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831163331.6c90c963@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=bfoster@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox