* [PATCH 00/11] mm/damon: misc fixups for documents, comments and its tracepoint @ 2023-09-07 2:29 SeongJae Park 2023-09-07 2:29 ` [PATCH 11/11] mm/damon/core: remove 'struct target *' parameter from damon_aggregated tracepoint SeongJae Park 0 siblings, 1 reply; 2+ messages in thread From: SeongJae Park @ 2023-09-07 2:29 UTC (permalink / raw) To: Andrew Morton Cc: SeongJae Park, Jonathan Corbet, Steven Rostedt, damon, linux-mm, linux-doc, linux-trace-kernel, linux-kernel This patchset contains miscellaneous simple fixups for documents, comments and tracepoint of DAMON. SeongJae Park (11): Docs/admin-guide/mm/damon/usage: fixup missed :ref: keyword Docs/admin-guide/mm/damon/usage: place debugfs usage at the bottom Docs/admin-guide/mm/damon/usage: move debugfs intro to the bottom of the section Docs/mm/damon/design: explicitly introduce ``nr_accesses`` Docs/admin-guide/mm/damon/usage: explain the format of damon_aggregate tracepoint Docs/mm/damon/design: add a section for kdamond and DAMON context Docs/admin-guide/mm/damon/usage: link design doc for details of kdamond and context mm/damon/core: fix a comment about damon_set_attrs() call timings mm/damon/core: add more comments for nr_accesses mm/damon/core: remove duplicated comment for watermarks-based deactivation mm/damon/core: remove 'struct target *' parameter from damon_aggregated tracepoint Documentation/admin-guide/mm/damon/usage.rst | 86 +++++++++++--------- Documentation/mm/damon/design.rst | 23 +++++- include/linux/damon.h | 22 ++--- include/trace/events/damon.h | 6 +- mm/damon/core.c | 8 +- 5 files changed, 90 insertions(+), 55 deletions(-) base-commit: ac8e8303c9c11b5c2e1d2e110866eb66c9fd771e -- 2.25.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 11/11] mm/damon/core: remove 'struct target *' parameter from damon_aggregated tracepoint 2023-09-07 2:29 [PATCH 00/11] mm/damon: misc fixups for documents, comments and its tracepoint SeongJae Park @ 2023-09-07 2:29 ` SeongJae Park 0 siblings, 0 replies; 2+ messages in thread From: SeongJae Park @ 2023-09-07 2:29 UTC (permalink / raw) To: Andrew Morton Cc: SeongJae Park, Steven Rostedt, damon, linux-mm, linux-trace-kernel, linux-kernel damon_aggregateed tracepoint is receiving 'struct target *', but doesn't use it. Remove it from the prototype. Signed-off-by: SeongJae Park <sj@kernel.org> --- include/trace/events/damon.h | 6 +++--- mm/damon/core.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h index c79f1d4c39af..0b8d13bde17a 100644 --- a/include/trace/events/damon.h +++ b/include/trace/events/damon.h @@ -11,10 +11,10 @@ TRACE_EVENT(damon_aggregated, - TP_PROTO(struct damon_target *t, unsigned int target_id, - struct damon_region *r, unsigned int nr_regions), + TP_PROTO(unsigned int target_id, struct damon_region *r, + unsigned int nr_regions), - TP_ARGS(t, target_id, r, nr_regions), + TP_ARGS(target_id, r, nr_regions), TP_STRUCT__entry( __field(unsigned long, target_id) diff --git a/mm/damon/core.c b/mm/damon/core.c index 1ce483a3c2b5..b895f70acb2d 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -805,7 +805,7 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) struct damon_region *r; damon_for_each_region(r, t) { - trace_damon_aggregated(t, ti, r, damon_nr_regions(t)); + trace_damon_aggregated(ti, r, damon_nr_regions(t)); r->last_nr_accesses = r->nr_accesses; r->nr_accesses = 0; } -- 2.25.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-07 2:29 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-07 2:29 [PATCH 00/11] mm/damon: misc fixups for documents, comments and its tracepoint SeongJae Park 2023-09-07 2:29 ` [PATCH 11/11] mm/damon/core: remove 'struct target *' parameter from damon_aggregated tracepoint SeongJae Park
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).