From: Steven Rostedt <rostedt@goodmis.org>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions
Date: Mon, 11 Sep 2023 16:51:44 -0400 [thread overview]
Message-ID: <20230911165144.5002a0ac@gandalf.local.home> (raw)
In-Reply-To: <20230911203642.1788-1-sj@kernel.org>
On Mon, 11 Sep 2023 20:36:42 +0000
SeongJae Park <sj@kernel.org> wrote:
> > Then tracing is fully enabled here, and now we enter:
> >
> > if (trace_damos_before_apply_enabled()) {
> > trace_damos_before_apply(cidx, sidx, tidx, r,
> > damon_nr_regions(t));
> > }
> >
> > Now the trace event is hit with sidx and tidx zero when they should not be.
> > This could confuse you when looking at the report.
>
> Thank you so much for enlightening me with this kind explanation, Steve! And
> this all make sense. I will follow your suggestion in the next spin.
>
> >
> > What I suggested was to initialize sidx to zero,
>
> Nit. Initialize to not zero but -1, right?
Yeah, but I was also thinking of the reset of it too :-p
sidx = -1;
if (trace_damos_before_apply_enabled()) {
sidx = 0;
-- Steve
>
> > set it in the first trace_*_enabled() check, and ignore calling the
> > tracepoint if it's not >= 0.
> >
next prev parent reply other threads:[~2023-09-12 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 4:59 [PATCH 0/2] mm/damon: add a tracepoint for damos apply target regions SeongJae Park
2023-09-11 4:59 ` [PATCH 1/2] mm/damon/core: " SeongJae Park
2023-09-11 18:19 ` Steven Rostedt
2023-09-11 19:05 ` SeongJae Park
2023-09-11 20:31 ` Steven Rostedt
2023-09-11 20:36 ` SeongJae Park
2023-09-11 20:51 ` Steven Rostedt [this message]
2023-09-12 1:43 ` SeongJae Park
2023-09-12 1:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911165144.5002a0ac@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).