From: Steven Rostedt <rostedt@goodmis.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ajay Kaher <akaher@vmware.com>
Subject: Re: [PATCH v4] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()
Date: Tue, 12 Sep 2023 09:33:22 -0400 [thread overview]
Message-ID: <20230912093322.759a7d2a@gandalf.local.home> (raw)
In-Reply-To: <20230912025808.668187-1-ruanjinjie@huawei.com>
On Tue, 12 Sep 2023 10:58:08 +0800
Jinjie Ruan <ruanjinjie@huawei.com> wrote:
This looks good. But I have a small nit.
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index ed367d713be0..8e0593d4c6a6 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -2296,6 +2296,7 @@ event_subsystem_dir(struct trace_array *tr, const char *name,
> struct trace_event_file *file, struct dentry *parent)
> {
> struct event_subsystem *system, *iter;
> + struct eventfs_file *ef;
> struct trace_subsystem_dir *dir;
> int res;
>
Can you move the ef below dir to keep the "upside-down x-mas tree" format:
struct event_subsystem *system, *iter;
struct trace_subsystem_dir *dir;
struct eventfs_file *ef;
int res;
That's easier to read.
Thanks!
-- Steve
prev parent reply other threads:[~2023-09-12 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 2:58 [PATCH v4] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec() Jinjie Ruan
2023-09-12 13:33 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912093322.759a7d2a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akaher@vmware.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox