From: Steven Rostedt <rostedt@goodmis.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>, Bin Liu <b-liu@ti.com>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/8] usb: gadget: reduce usb gadget trace event buffer usage
Date: Thu, 14 Sep 2023 12:42:59 -0400 [thread overview]
Message-ID: <20230914124259.7bc383f8@gandalf.local.home> (raw)
In-Reply-To: <20230914100302.30274-1-quic_linyyuan@quicinc.com>
On Thu, 14 Sep 2023 18:02:54 +0800
Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
> some trace event use an interger to to save a bit field info of gadget,
> also some trace save endpoint name in string forat, it all can be
> chagned to other way at trace event store phase.
>
> bit field can be replace with a union interger member which include
> multiple bit fields.
>
> ep name stringe can be replace to a interger which contaion number
> and dir info.
>
> to allow trace output stage can get bit info from save interger,
> add DECLARE_EVENT_CLASS_PRINT_INIT() clas which allow user defined
> operation before print.
>
> v1: https://lore.kernel.org/linux-usb/20230911042843.2711-1-quic_linyyuan@quicinc.com/
> v2: fix two compile issues that COMPILE_TEST not covered
> https://lore.kernel.org/linux-usb/20230911112446.1791-1-quic_linyyuan@quicinc.com/
> v3: fix reviewer comments, allow bit fields work on both little and big endian
> https://lore.kernel.org/linux-usb/20230912104455.7737-1-quic_linyyuan@quicinc.com/
> v4: add DECLARE_EVENT_CLASS_PRINT_INIT() new trace class and use it
>
All these changes make it useless for user space. :-(
-- Steve
> Linyu Yuan (8):
> trace: add new DECLARE_EVENT_CLASS_PRINT_INIT class type
> usb: gadget: add anonymous definition in some struct for trace purpose
> usb: udc: trace: reduce buffer usage of trace event
> usb: cdns3: trace: reduce buffer usage of trace event
> usb: dwc3: trace: reduce buffer usage of trace event
> usb: cdns2: trace: reduce buffer usage of trace event
> usb: mtu3: trace: reduce buffer usage of trace event
> usb: musb: trace: reduce buffer usage of trace event
>
> drivers/usb/cdns3/cdns3-trace.h | 201 ++++++++++++++-------
> drivers/usb/cdns3/cdnsp-trace.h | 105 +++++++----
> drivers/usb/dwc3/trace.h | 99 ++++++----
> drivers/usb/gadget/udc/cdns2/cdns2-trace.h | 175 ++++++++++++------
> drivers/usb/gadget/udc/trace.h | 154 +++++++---------
> drivers/usb/mtu3/mtu3_trace.h | 76 +++++---
> drivers/usb/musb/musb_trace.h | 20 +-
> include/linux/tracepoint.h | 22 +++
> include/linux/usb/gadget.h | 113 +++++++-----
> include/trace/bpf_probe.h | 4 +
> include/trace/perf.h | 43 +++++
> include/trace/stages/stage3_trace_output.h | 3 +
> include/trace/trace_events.h | 118 ++++++++++++
> 13 files changed, 784 insertions(+), 349 deletions(-)
>
prev parent reply other threads:[~2023-09-14 16:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 10:02 [PATCH 0/8] usb: gadget: reduce usb gadget trace event buffer usage Linyu Yuan
2023-09-14 10:02 ` [PATCH 1/8] trace: add new DECLARE_EVENT_CLASS_PRINT_INIT class type Linyu Yuan
2023-09-14 14:29 ` kernel test robot
2023-09-14 10:02 ` [PATCH 2/8] usb: gadget: add anonymous definition in some struct for trace purpose Linyu Yuan
2023-09-14 14:54 ` Alan Stern
2023-09-15 1:02 ` Linyu Yuan
2023-09-15 1:51 ` Alan Stern
2023-09-15 1:56 ` Linyu Yuan
2023-09-14 10:02 ` [PATCH 3/8] usb: udc: trace: reduce buffer usage of trace event Linyu Yuan
2023-09-14 16:54 ` Steven Rostedt
2023-09-15 1:11 ` Linyu Yuan
2023-09-15 2:16 ` Steven Rostedt
2023-09-15 2:25 ` Linyu Yuan
2023-09-14 10:02 ` [PATCH 4/8] usb: cdns3: " Linyu Yuan
2023-09-14 10:02 ` [PATCH 5/8] usb: dwc3: " Linyu Yuan
2023-09-14 10:03 ` [PATCH 6/8] usb: cdns2: " Linyu Yuan
2023-09-14 10:03 ` [PATCH 7/8] usb: mtu3: " Linyu Yuan
2023-09-14 10:03 ` [PATCH 8/8] usb: musb: " Linyu Yuan
2023-09-14 16:42 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914124259.7bc383f8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=quic_linyyuan@quicinc.com \
--cc=rogerq@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).