From: Steven Rostedt <rostedt@goodmis.org>
To: Ross Zwisler <zwisler@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ross Zwisler <zwisler@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Daniel Almeida <daniel.almeida@collabora.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH] visl: use canonical ftrace path
Date: Tue, 3 Oct 2023 17:41:29 -0400 [thread overview]
Message-ID: <20231003174129.11c79c18@gandalf.local.home> (raw)
In-Reply-To: <20230829204600.3210276-2-zwisler@kernel.org>
Could this go through the linux-media tree, or if you give it an Ack, I'll
take it through the tracing tree.
-- Steve
On Tue, 29 Aug 2023 14:46:01 -0600
Ross Zwisler <zwisler@kernel.org> wrote:
> From: Ross Zwisler <zwisler@google.com>
>
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
>
> But, from Documentation/trace/ftrace.rst:
>
> Before 4.1, all ftrace tracing control files were within the debugfs
> file system, which is typically located at /sys/kernel/debug/tracing.
> For backward compatibility, when mounting the debugfs file system,
> the tracefs file system will be automatically mounted at:
>
> /sys/kernel/debug/tracing
>
> Update the visl decoder driver documentation to use this tracefs path.
>
> Signed-off-by: Ross Zwisler <zwisler@google.com>
> ---
> Documentation/admin-guide/media/visl.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/media/visl.rst b/Documentation/admin-guide/media/visl.rst
> index 7d2dc78341c9..4328c6c72d30 100644
> --- a/Documentation/admin-guide/media/visl.rst
> +++ b/Documentation/admin-guide/media/visl.rst
> @@ -78,7 +78,7 @@ The trace events are defined on a per-codec basis, e.g.:
>
> .. code-block:: bash
>
> - $ ls /sys/kernel/debug/tracing/events/ | grep visl
> + $ ls /sys/kernel/tracing/events/ | grep visl
> visl_fwht_controls
> visl_h264_controls
> visl_hevc_controls
> @@ -90,13 +90,13 @@ For example, in order to dump HEVC SPS data:
>
> .. code-block:: bash
>
> - $ echo 1 > /sys/kernel/debug/tracing/events/visl_hevc_controls/v4l2_ctrl_hevc_sps/enable
> + $ echo 1 > /sys/kernel/tracing/events/visl_hevc_controls/v4l2_ctrl_hevc_sps/enable
>
> The SPS data will be dumped to the trace buffer, i.e.:
>
> .. code-block:: bash
>
> - $ cat /sys/kernel/debug/tracing/trace
> + $ cat /sys/kernel/tracing/trace
> video_parameter_set_id 0
> seq_parameter_set_id 0
> pic_width_in_luma_samples 1920
next prev parent reply other threads:[~2023-10-03 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 20:46 [PATCH] visl: use canonical ftrace path Ross Zwisler
2023-08-31 0:12 ` Masami Hiramatsu
2023-08-31 13:39 ` Steven Rostedt
2023-10-03 21:41 ` Steven Rostedt [this message]
2023-10-04 6:33 ` Hans Verkuil
2023-10-04 13:57 ` Steven Rostedt
2023-10-04 14:00 ` Hans Verkuil
2023-10-04 14:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003174129.11c79c18@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=daniel.almeida@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mhiramat@kernel.org \
--cc=zwisler@google.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).