* [PATCH v1] samples: kprobes: Fixes a typo
@ 2023-08-17 17:08 Atul Kumar Pant
2023-09-23 17:30 ` Atul Kumar Pant
0 siblings, 1 reply; 7+ messages in thread
From: Atul Kumar Pant @ 2023-08-17 17:08 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat
Cc: Atul Kumar Pant, linux-kernel, linux-trace-kernel,
linux-kernel-mentees, shuah
Fixes typo in a function name.
Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
---
samples/kprobes/kretprobe_example.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
index cbf16542d84e..ed79fd3d48fb 100644
--- a/samples/kprobes/kretprobe_example.c
+++ b/samples/kprobes/kretprobe_example.c
@@ -35,7 +35,7 @@ struct my_data {
ktime_t entry_stamp;
};
-/* Here we use the entry_hanlder to timestamp function entry */
+/* Here we use the entry_handler to timestamp function entry */
static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
{
struct my_data *data;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1] samples: kprobes: Fixes a typo
2023-08-17 17:08 [PATCH v1] samples: kprobes: Fixes a typo Atul Kumar Pant
@ 2023-09-23 17:30 ` Atul Kumar Pant
2023-10-07 15:39 ` Atul Kumar Pant
0 siblings, 1 reply; 7+ messages in thread
From: Atul Kumar Pant @ 2023-09-23 17:30 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat
Cc: linux-kernel, linux-trace-kernel, linux-kernel-mentees, shuah
On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> Fixes typo in a function name.
>
> Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> ---
> samples/kprobes/kretprobe_example.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> index cbf16542d84e..ed79fd3d48fb 100644
> --- a/samples/kprobes/kretprobe_example.c
> +++ b/samples/kprobes/kretprobe_example.c
> @@ -35,7 +35,7 @@ struct my_data {
> ktime_t entry_stamp;
> };
>
> -/* Here we use the entry_hanlder to timestamp function entry */
> +/* Here we use the entry_handler to timestamp function entry */
> static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> {
> struct my_data *data;
> --
> 2.25.1
>
Hi all, can someone provide comments on this change.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] samples: kprobes: Fixes a typo
2023-09-23 17:30 ` Atul Kumar Pant
@ 2023-10-07 15:39 ` Atul Kumar Pant
2023-10-09 13:51 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: Atul Kumar Pant @ 2023-10-07 15:39 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat
Cc: linux-kernel, linux-trace-kernel, linux-kernel-mentees, shuah
On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > Fixes typo in a function name.
> >
> > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > ---
> > samples/kprobes/kretprobe_example.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > index cbf16542d84e..ed79fd3d48fb 100644
> > --- a/samples/kprobes/kretprobe_example.c
> > +++ b/samples/kprobes/kretprobe_example.c
> > @@ -35,7 +35,7 @@ struct my_data {
> > ktime_t entry_stamp;
> > };
> >
> > -/* Here we use the entry_hanlder to timestamp function entry */
> > +/* Here we use the entry_handler to timestamp function entry */
> > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > {
> > struct my_data *data;
> > --
> > 2.25.1
> >
>
> Hi all, can someone provide comments on this change.
Hi all, can someone please review this change. It has been not
reviewed for quite some time.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] samples: kprobes: Fixes a typo
2023-10-07 15:39 ` Atul Kumar Pant
@ 2023-10-09 13:51 ` Steven Rostedt
2023-10-09 15:03 ` Masami Hiramatsu
2023-10-11 18:02 ` Atul Kumar Pant
0 siblings, 2 replies; 7+ messages in thread
From: Steven Rostedt @ 2023-10-09 13:51 UTC (permalink / raw)
To: Atul Kumar Pant
Cc: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat, linux-kernel,
linux-trace-kernel, linux-kernel-mentees, shuah
On Sat, 7 Oct 2023 21:09:00 +0530
Atul Kumar Pant <atulpant.linux@gmail.com> wrote:
> On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > Fixes typo in a function name.
> > >
> > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > > ---
> > > samples/kprobes/kretprobe_example.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > index cbf16542d84e..ed79fd3d48fb 100644
> > > --- a/samples/kprobes/kretprobe_example.c
> > > +++ b/samples/kprobes/kretprobe_example.c
> > > @@ -35,7 +35,7 @@ struct my_data {
> > > ktime_t entry_stamp;
> > > };
> > >
> > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > +/* Here we use the entry_handler to timestamp function entry */
> > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > {
> > > struct my_data *data;
> > > --
> > > 2.25.1
> > >
> >
> > Hi all, can someone provide comments on this change.
>
> Hi all, can someone please review this change. It has been not
> reviewed for quite some time.
That's because trivial typos in comments are considered very low priority,
and are usually only added (if they are ever added) if the maintainer has
extra time, which may not be for a while.
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] samples: kprobes: Fixes a typo
2023-10-09 13:51 ` Steven Rostedt
@ 2023-10-09 15:03 ` Masami Hiramatsu
2023-10-11 18:04 ` Atul Kumar Pant
2023-10-11 18:02 ` Atul Kumar Pant
1 sibling, 1 reply; 7+ messages in thread
From: Masami Hiramatsu @ 2023-10-09 15:03 UTC (permalink / raw)
To: Steven Rostedt
Cc: Atul Kumar Pant, naveen.n.rao, anil.s.keshavamurthy, davem,
mhiramat, linux-kernel, linux-trace-kernel, linux-kernel-mentees,
shuah
On Mon, 9 Oct 2023 09:51:03 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 7 Oct 2023 21:09:00 +0530
> Atul Kumar Pant <atulpant.linux@gmail.com> wrote:
>
> > On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > > Fixes typo in a function name.
> > > >
> > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > > > ---
> > > > samples/kprobes/kretprobe_example.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > > index cbf16542d84e..ed79fd3d48fb 100644
> > > > --- a/samples/kprobes/kretprobe_example.c
> > > > +++ b/samples/kprobes/kretprobe_example.c
> > > > @@ -35,7 +35,7 @@ struct my_data {
> > > > ktime_t entry_stamp;
> > > > };
> > > >
> > > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > > +/* Here we use the entry_handler to timestamp function entry */
> > > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > > {
> > > > struct my_data *data;
> > > > --
> > > > 2.25.1
> > > >
> > >
> > > Hi all, can someone provide comments on this change.
> >
> > Hi all, can someone please review this change. It has been not
> > reviewed for quite some time.
>
> That's because trivial typos in comments are considered very low priority,
> and are usually only added (if they are ever added) if the maintainer has
> extra time, which may not be for a while.
Anyway, let me pick this. I found this in my inbox now. :)
Thank you,
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] samples: kprobes: Fixes a typo
2023-10-09 13:51 ` Steven Rostedt
2023-10-09 15:03 ` Masami Hiramatsu
@ 2023-10-11 18:02 ` Atul Kumar Pant
1 sibling, 0 replies; 7+ messages in thread
From: Atul Kumar Pant @ 2023-10-11 18:02 UTC (permalink / raw)
To: Steven Rostedt
Cc: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat, linux-kernel,
linux-trace-kernel, linux-kernel-mentees, shuah
On Mon, Oct 09, 2023 at 09:51:03AM -0400, Steven Rostedt wrote:
> On Sat, 7 Oct 2023 21:09:00 +0530
> Atul Kumar Pant <atulpant.linux@gmail.com> wrote:
>
> > On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > > Fixes typo in a function name.
> > > >
> > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > > > ---
> > > > samples/kprobes/kretprobe_example.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > > index cbf16542d84e..ed79fd3d48fb 100644
> > > > --- a/samples/kprobes/kretprobe_example.c
> > > > +++ b/samples/kprobes/kretprobe_example.c
> > > > @@ -35,7 +35,7 @@ struct my_data {
> > > > ktime_t entry_stamp;
> > > > };
> > > >
> > > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > > +/* Here we use the entry_handler to timestamp function entry */
> > > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > > {
> > > > struct my_data *data;
> > > > --
> > > > 2.25.1
> > > >
> > >
> > > Hi all, can someone provide comments on this change.
> >
> > Hi all, can someone please review this change. It has been not
> > reviewed for quite some time.
>
> That's because trivial typos in comments are considered very low priority,
> and are usually only added (if they are ever added) if the maintainer has
> extra time, which may not be for a while.
>
> -- Steve
Thank you Steve for the response. I wasn't aware of this.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] samples: kprobes: Fixes a typo
2023-10-09 15:03 ` Masami Hiramatsu
@ 2023-10-11 18:04 ` Atul Kumar Pant
0 siblings, 0 replies; 7+ messages in thread
From: Atul Kumar Pant @ 2023-10-11 18:04 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: Steven Rostedt, naveen.n.rao, anil.s.keshavamurthy, davem,
linux-kernel, linux-trace-kernel, linux-kernel-mentees, shuah
On Tue, Oct 10, 2023 at 12:03:56AM +0900, Masami Hiramatsu wrote:
> On Mon, 9 Oct 2023 09:51:03 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > On Sat, 7 Oct 2023 21:09:00 +0530
> > Atul Kumar Pant <atulpant.linux@gmail.com> wrote:
> >
> > > On Sat, Sep 23, 2023 at 11:00:46PM +0530, Atul Kumar Pant wrote:
> > > > On Thu, Aug 17, 2023 at 10:38:19PM +0530, Atul Kumar Pant wrote:
> > > > > Fixes typo in a function name.
> > > > >
> > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > > > > ---
> > > > > samples/kprobes/kretprobe_example.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> > > > > index cbf16542d84e..ed79fd3d48fb 100644
> > > > > --- a/samples/kprobes/kretprobe_example.c
> > > > > +++ b/samples/kprobes/kretprobe_example.c
> > > > > @@ -35,7 +35,7 @@ struct my_data {
> > > > > ktime_t entry_stamp;
> > > > > };
> > > > >
> > > > > -/* Here we use the entry_hanlder to timestamp function entry */
> > > > > +/* Here we use the entry_handler to timestamp function entry */
> > > > > static int entry_handler(struct kretprobe_instance *ri, struct pt_regs *regs)
> > > > > {
> > > > > struct my_data *data;
> > > > > --
> > > > > 2.25.1
> > > > >
> > > >
> > > > Hi all, can someone provide comments on this change.
> > >
> > > Hi all, can someone please review this change. It has been not
> > > reviewed for quite some time.
> >
> > That's because trivial typos in comments are considered very low priority,
> > and are usually only added (if they are ever added) if the maintainer has
> > extra time, which may not be for a while.
>
> Anyway, let me pick this. I found this in my inbox now. :)
Thank you. Sorry for the redundant emails for reviewing the change :)
>
> Thank you,
>
> >
> > -- Steve
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-10-11 18:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-17 17:08 [PATCH v1] samples: kprobes: Fixes a typo Atul Kumar Pant
2023-09-23 17:30 ` Atul Kumar Pant
2023-10-07 15:39 ` Atul Kumar Pant
2023-10-09 13:51 ` Steven Rostedt
2023-10-09 15:03 ` Masami Hiramatsu
2023-10-11 18:04 ` Atul Kumar Pant
2023-10-11 18:02 ` Atul Kumar Pant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).