* [PATCH] powerpc: Remove initialisation of readpos
@ 2023-10-24 14:55 Matthew Wilcox (Oracle)
2023-10-24 21:50 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox (Oracle) @ 2023-10-24 14:55 UTC (permalink / raw)
To: Steven Rostedt
Cc: Matthew Wilcox (Oracle), Kees Cook, Christoph Hellwig,
Justin Stitt, linux-hardening, linux-kernel, linux-trace-kernel,
Kent Overstreet, Petr Mladek, Andy Shevchenko, Rasmus Villemoes,
Sergey Senozhatsky, Michael Ellerman
While powerpc doesn't use the seq_buf readpos, it did explicitly
initialise it for no good reason.
Fixes: d0ed46b60396 ("tracing: Move readpos from seq_buf to trace_seq")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
arch/powerpc/kernel/setup-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 2f1026fba00d..34975532e44c 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -601,7 +601,6 @@ struct seq_buf ppc_hw_desc __initdata = {
.buffer = ppc_hw_desc_buf,
.size = sizeof(ppc_hw_desc_buf),
.len = 0,
- .readpos = 0,
};
static __init void probe_machine(void)
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] powerpc: Remove initialisation of readpos
2023-10-24 14:55 [PATCH] powerpc: Remove initialisation of readpos Matthew Wilcox (Oracle)
@ 2023-10-24 21:50 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2023-10-24 21:50 UTC (permalink / raw)
To: Matthew Wilcox (Oracle)
Cc: Steven Rostedt, Christoph Hellwig, Justin Stitt, linux-hardening,
linux-kernel, linux-trace-kernel, Kent Overstreet, Petr Mladek,
Andy Shevchenko, Rasmus Villemoes, Sergey Senozhatsky,
Michael Ellerman
On Tue, Oct 24, 2023 at 03:55:59PM +0100, Matthew Wilcox (Oracle) wrote:
> While powerpc doesn't use the seq_buf readpos, it did explicitly
> initialise it for no good reason.
>
> Fixes: d0ed46b60396 ("tracing: Move readpos from seq_buf to trace_seq")
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Yeah, looks right -- it'd even be right if the member still existed. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-24 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-24 14:55 [PATCH] powerpc: Remove initialisation of readpos Matthew Wilcox (Oracle)
2023-10-24 21:50 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).