From: Steven Rostedt <rostedt@goodmis.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux trace kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
"Naresh Kamboju <naresh.kamboju@linaro.org>,
Beau Belgrave <beaub@linux.microsoft.com>,
Ajay Kaher <akaher@vmware.com>,
Andrew Morton" <akpm@linux-foundation.org>,
lkft-triage@lists.linaro.org
Subject: Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry
Date: Sun, 29 Oct 2023 09:14:08 -0400 [thread overview]
Message-ID: <20231029091408.0179cee4@rorschach.local.home> (raw)
In-Reply-To: <CA+G9fYsL=wK_rn8ovCHtn6QXrvzv0a67oj9U3u6r9i-dxjsqwQ@mail.gmail.com>
On Sun, 29 Oct 2023 12:31:54 +0530
Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> Following build errors have been noticed.
>
> fs/tracefs/event_inode.c:348:1: error: return type defaults to 'int'
> [-Werror=implicit-int]
> 348 | create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei,
> | ^~~~~~~~~~~~~~~~~
> In file included from include/uapi/linux/posix_types.h:5,
> from include/uapi/linux/types.h:14,
> from include/linux/types.h:6,
> from include/linux/kasan-checks.h:5,
> from include/asm-generic/rwonce.h:26,
> from ./arch/x86/include/generated/asm/rwonce.h:1,
This patch passed all my tests, I have no idea how the above happened.
The "return type defaults to int" tells me the "static struct dentry *"
part of the patch may have been clipped.
Are you sure it was applied correctly? Perhaps check out the branch I
have and let me know if you get the same errors.
git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git trace/core
-- Steve
next prev parent reply other threads:[~2023-10-29 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 20:46 [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry Steven Rostedt
2023-10-29 3:19 ` Masami Hiramatsu
2023-10-29 7:01 ` Naresh Kamboju
2023-10-29 13:14 ` Steven Rostedt [this message]
2023-10-30 7:07 ` Naresh Kamboju
2023-10-30 14:41 ` Steven Rostedt
2023-10-30 21:03 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029091408.0179cee4@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox