Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] eventfs: Fix kerneldoc of eventfs_remove_rec()
Date: Thu, 2 Nov 2023 08:36:34 -0400	[thread overview]
Message-ID: <20231102083634.5278a500@gandalf.local.home> (raw)
In-Reply-To: <0be16a8e-5f4f-4c26-d6b1-c090accfac5c@quicinc.com>

On Thu, 2 Nov 2023 12:05:33 +0530
Mukesh Ojha <quic_mojha@quicinc.com> wrote:

> I will try to participate and take this in a good way..but i thought
> for easier change where there is no discussion is needed., it is fine
> to add if you have spent time in checking the code and change is proper.

If it's easy then automated bots will likely catch any issues. No need to
say you looked at it too. Otherwise we'll get 20 Reviewed-by tags on
comment changes.

A Reviewed-by tag has much more meaning when the code being reviewed is not
trivial, where questions about correctness is needed. In other words, if
something doesn't look quite right, ask. If it is, and the author explains
the reason it is, the fact that the explanation is now documented in the
archives is useful.

Thanks,

-- Steve

      reply	other threads:[~2023-11-02 12:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30 16:15 [PATCH] eventfs: Fix kerneldoc of eventfs_remove_rec() Steven Rostedt
2023-10-30 16:27 ` Mukesh Ojha
2023-11-01 20:00   ` Steven Rostedt
2023-11-02  6:35     ` Mukesh Ojha
2023-11-02 12:36       ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231102083634.5278a500@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=quic_mojha@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox