From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A00B212E47; Wed, 8 Nov 2023 10:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ldiga5qq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3C87C433C7; Wed, 8 Nov 2023 10:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699439274; bh=jPTCkhBc7PI9MxQBx8eZ6M1FUClONYHAJL7rPOuMKIk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ldiga5qq8VhgdAX6zRPKPVR6J7ovztl6429iDYp8512IacCZgszC+ILd6dOXkfo4v t5wfjDd6YBQ5ilv5qwESULiVtvxrBQx176CSYiN6i1sPaJghieI3M1eeMMRoOefqCf O+iz2Q5HsPYzw7wCoieoHfeS8i/uuey40FGqT5Ey7fkiqKOKjRh5pmaEjsK+LSN2jS Parqy+HpitkBCXQIP3xBPG8ypHcAfcQTw+ngWwR4YeRpkN+yzFew1je/X4E1KyDSU7 YcEeIiRAgSItLvqJJ6VNflmLmL2IsTXZ/VPvh9vwMZ30c0Fipa9GWEnTB2JFYnZQ19 sZXk8l/GMb4gg== Date: Wed, 8 Nov 2023 19:27:41 +0900 From: Masami Hiramatsu (Google) To: Cc: Joel Granados via B4 Relay , Luis Chamberlain , willy@infradead.org, josh@joshtriplett.org, Kees Cook , Eric Biederman , Iurii Zaikin , Steven Rostedt , Mark Rutland , Thomas Gleixner , John Stultz , Stephen Boyd , Andy Lutomirski , Will Drewry , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Petr Mladek , John Ogness , Sergey Senozhatsky , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Balbir Singh , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 08/10] kprobes: Remove the now superfluous sentinel elements from ctl_table array Message-Id: <20231108192741.72a341b73270d3c04d6dbc51@kernel.org> In-Reply-To: <20231107-jag-sysctl_remove_empty_elem_kernel-v1-8-e4ce1388dfa0@samsung.com> References: <20231107-jag-sysctl_remove_empty_elem_kernel-v1-0-e4ce1388dfa0@samsung.com> <20231107-jag-sysctl_remove_empty_elem_kernel-v1-8-e4ce1388dfa0@samsung.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 07 Nov 2023 14:45:08 +0100 Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > Remove sentinel element from kprobe_sysclts Looks good to me. Acked-by: Masami Hiramatsu (Google) Thanks, > > Signed-off-by: Joel Granados > --- > kernel/kprobes.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 0c6185aefaef..d049b602dd41 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -968,7 +968,6 @@ static struct ctl_table kprobe_sysctls[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > - {} > }; > > static void __init kprobe_sysctls_init(void) > > -- > 2.30.2 > -- Masami Hiramatsu (Google)