From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384E511C93; Wed, 8 Nov 2023 10:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HrDtYH6e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 510AEC433C7; Wed, 8 Nov 2023 10:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699439403; bh=6ZoI2ba6vIpYYpfl0ANvHJHV0XAA/rAOGYtXoD2uuRg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HrDtYH6eKjPaP8v6C+1BefyGqlLRNHZLg4zWFl2q2QUVcr7vOhiJnEOU1P7PzPRGW rr9xwIo7hc0KEJzD3Xu48pmTcEY4ol+81jw17pVnZ3UrZPLc83DkYE37aed4UQsOpO Z83ayotG0vUMkFyVhsUk46QARRmFh+OJCGHIMWqn/m18j7pOHgU1OUrI+IKGkZ9keL HPl/fKRfcRaS5wdaiXx8JRMH4VGF5DHPc2ye1hCRD6ybC5iTR5hn+uSJ4ZvCJtTxS1 b08UMZRk0sMZFU2ordnozCblbqfjycozFB+qW7YNPDrynRFmFjUVg/IpmaQkHVQGMr XQm6NwocnGgNQ== Date: Wed, 8 Nov 2023 19:29:49 +0900 From: Masami Hiramatsu (Google) To: Cc: Joel Granados via B4 Relay , Luis Chamberlain , willy@infradead.org, josh@joshtriplett.org, Kees Cook , Eric Biederman , Iurii Zaikin , Steven Rostedt , Mark Rutland , Thomas Gleixner , John Stultz , Stephen Boyd , Andy Lutomirski , Will Drewry , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Petr Mladek , John Ogness , Sergey Senozhatsky , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Balbir Singh , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 03/10] ftrace: Remove the now superfluous sentinel elements from ctl_table array Message-Id: <20231108192949.f19832c76d1cf18c5d614e72@kernel.org> In-Reply-To: <20231107-jag-sysctl_remove_empty_elem_kernel-v1-3-e4ce1388dfa0@samsung.com> References: <20231107-jag-sysctl_remove_empty_elem_kernel-v1-0-e4ce1388dfa0@samsung.com> <20231107-jag-sysctl_remove_empty_elem_kernel-v1-3-e4ce1388dfa0@samsung.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 07 Nov 2023 14:45:03 +0100 Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > Remove sentinel elements from ftrace_sysctls and user_event_sysctls > Both looks good to me. (since register_sysctl_init() uses ARRAY_SIZE() macro to get the array size.) Acked-by: Masami Hiramatsu (Google) > Signed-off-by: Joel Granados > --- > kernel/trace/ftrace.c | 1 - > kernel/trace/trace_events_user.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 8de8bec5f366..fd40d02a23c7 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -8264,7 +8264,6 @@ static struct ctl_table ftrace_sysctls[] = { > .mode = 0644, > .proc_handler = ftrace_enable_sysctl, > }, > - {} > }; > > static int __init ftrace_sysctl_init(void) > diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c > index 6f046650e527..bef1bdc62acf 100644 > --- a/kernel/trace/trace_events_user.c > +++ b/kernel/trace/trace_events_user.c > @@ -2694,7 +2694,6 @@ static struct ctl_table user_event_sysctls[] = { > .mode = 0644, > .proc_handler = set_max_user_events_sysctl, > }, > - {} > }; > > static int __init trace_events_user_init(void) > > -- > 2.30.2 > -- Masami Hiramatsu (Google)