* [PATCH] tracing/kprobes: Fix the order of argument descriptions
@ 2023-10-31 4:13 Yujie Liu
2023-10-31 9:48 ` Mukesh Ojha
0 siblings, 1 reply; 3+ messages in thread
From: Yujie Liu @ 2023-10-31 4:13 UTC (permalink / raw)
To: linux-trace-kernel
Cc: Masami Hiramatsu, Steven Rostedt, Tom Zanussi, linux-kernel,
Mukesh Ojha
The order of descriptions should be consistent with the argument list of
the function, so "kretprobe" should be the second one.
int __kprobe_event_gen_cmd_start(struct dynevent_cmd *cmd, bool kretprobe,
const char *name, const char *loc, ...)
Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
Suggested-by: Mukesh Ojha <quic_mojha@quicinc.com>
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
kernel/trace/trace_kprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index e834f149695b..47812aa16bb5 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -1020,9 +1020,9 @@ EXPORT_SYMBOL_GPL(kprobe_event_cmd_init);
/**
* __kprobe_event_gen_cmd_start - Generate a kprobe event command from arg list
* @cmd: A pointer to the dynevent_cmd struct representing the new event
+ * @kretprobe: Is this a return probe?
* @name: The name of the kprobe event
* @loc: The location of the kprobe event
- * @kretprobe: Is this a return probe?
* @...: Variable number of arg (pairs), one pair for each field
*
* NOTE: Users normally won't want to call this function directly, but
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing/kprobes: Fix the order of argument descriptions
2023-10-31 4:13 [PATCH] tracing/kprobes: Fix the order of argument descriptions Yujie Liu
@ 2023-10-31 9:48 ` Mukesh Ojha
2023-11-10 23:01 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Mukesh Ojha @ 2023-10-31 9:48 UTC (permalink / raw)
To: Yujie Liu, linux-trace-kernel
Cc: Masami Hiramatsu, Steven Rostedt, Tom Zanussi, linux-kernel
On 10/31/2023 9:43 AM, Yujie Liu wrote:
> The order of descriptions should be consistent with the argument list of
> the function, so "kretprobe" should be the second one.
>
> int __kprobe_event_gen_cmd_start(struct dynevent_cmd *cmd, bool kretprobe,
> const char *name, const char *loc, ...)
>
> Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
> Suggested-by: Mukesh Ojha <quic_mojha@quicinc.com>
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
Thanks.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> ---
> kernel/trace/trace_kprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index e834f149695b..47812aa16bb5 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -1020,9 +1020,9 @@ EXPORT_SYMBOL_GPL(kprobe_event_cmd_init);
> /**
> * __kprobe_event_gen_cmd_start - Generate a kprobe event command from arg list
> * @cmd: A pointer to the dynevent_cmd struct representing the new event
> + * @kretprobe: Is this a return probe?
> * @name: The name of the kprobe event
> * @loc: The location of the kprobe event
> - * @kretprobe: Is this a return probe?
> * @...: Variable number of arg (pairs), one pair for each field
> *
> * NOTE: Users normally won't want to call this function directly, but
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing/kprobes: Fix the order of argument descriptions
2023-10-31 9:48 ` Mukesh Ojha
@ 2023-11-10 23:01 ` Masami Hiramatsu
0 siblings, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2023-11-10 23:01 UTC (permalink / raw)
To: Mukesh Ojha
Cc: Yujie Liu, linux-trace-kernel, Masami Hiramatsu, Steven Rostedt,
Tom Zanussi, linux-kernel
On Tue, 31 Oct 2023 15:18:14 +0530
Mukesh Ojha <quic_mojha@quicinc.com> wrote:
>
>
> On 10/31/2023 9:43 AM, Yujie Liu wrote:
> > The order of descriptions should be consistent with the argument list of
> > the function, so "kretprobe" should be the second one.
> >
> > int __kprobe_event_gen_cmd_start(struct dynevent_cmd *cmd, bool kretprobe,
> > const char *name, const char *loc, ...)
> >
> > Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
> > Suggested-by: Mukesh Ojha <quic_mojha@quicinc.com>
> > Signed-off-by: Yujie Liu <yujie.liu@intel.com>
>
> Thanks.
>
> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
OK, let me pick this to probes/fixes.
Thanks!
>
> -Mukesh
>
> > ---
> > kernel/trace/trace_kprobe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> > index e834f149695b..47812aa16bb5 100644
> > --- a/kernel/trace/trace_kprobe.c
> > +++ b/kernel/trace/trace_kprobe.c
> > @@ -1020,9 +1020,9 @@ EXPORT_SYMBOL_GPL(kprobe_event_cmd_init);
> > /**
> > * __kprobe_event_gen_cmd_start - Generate a kprobe event command from arg list
> > * @cmd: A pointer to the dynevent_cmd struct representing the new event
> > + * @kretprobe: Is this a return probe?
> > * @name: The name of the kprobe event
> > * @loc: The location of the kprobe event
> > - * @kretprobe: Is this a return probe?
> > * @...: Variable number of arg (pairs), one pair for each field
> > *
> > * NOTE: Users normally won't want to call this function directly, but
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-10 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-31 4:13 [PATCH] tracing/kprobes: Fix the order of argument descriptions Yujie Liu
2023-10-31 9:48 ` Mukesh Ojha
2023-11-10 23:01 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).