From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Tejun Heo <tj@kernel.org>, Azeem Shaikh <azeemshaikh38@gmail.com>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Waiman Long <longman@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 0/3] kernfs: Convert from strlcpy() to strscpy()
Date: Mon, 27 Nov 2023 13:43:57 +0000 [thread overview]
Message-ID: <2023112751-cozy-dangle-3f5a@gregkh> (raw)
In-Reply-To: <20231116191718.work.246-kees@kernel.org>
On Thu, Nov 16, 2023 at 11:21:22AM -0800, Kees Cook wrote:
> Hi,
>
> One of the last users of strlcpy() is kernfs, which has some complex
> calling hierarchies that needed to be carefully examined. This series
> refactors the strlcpy() calls into strscpy() calls, and bubbles up all
> changes in return value checking for callers.
Why not work instead to convert kernfs (and by proxy cgroups) to use the
"safe" string functions based on seq_file? This should be a simpler
patch series to review, and implement on a per-function basis, and then
we would not have any string functions in kernfs anymore.
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-27 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 19:21 [PATCH 0/3] kernfs: Convert from strlcpy() to strscpy() Kees Cook
2023-11-16 19:21 ` [PATCH 1/3] kernfs: Convert kernfs_walk_ns() " Kees Cook
2023-11-16 19:21 ` [PATCH 2/3] kernfs: Convert kernfs_name_locked() " Kees Cook
2023-11-16 19:21 ` [PATCH 3/3] kernfs: Convert kernfs_path_from_node_locked() " Kees Cook
2023-11-17 13:47 ` Steven Rostedt
2023-11-18 3:33 ` Kees Cook
2023-11-27 13:43 ` Greg Kroah-Hartman [this message]
2023-11-28 0:38 ` [PATCH 0/3] kernfs: Convert " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112751-cozy-dangle-3f5a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=azeemshaikh38@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).