From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E64E35888 for ; Tue, 28 Nov 2023 14:20:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26D25C433C7; Tue, 28 Nov 2023 14:20:08 +0000 (UTC) Date: Tue, 28 Nov 2023 09:20:29 -0500 From: Steven Rostedt To: Dmytro Maluka Cc: LKML , Linux Trace Kernel , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Sean Paul , Arun Easi , Daniel Wagner Subject: Re: [RFC][PATCH] tracing: Allow creating instances with specified system events Message-ID: <20231128092029.342f5f03@gandalf.local.home> In-Reply-To: References: <20231127174108.3c331c9c@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Nov 2023 14:14:29 +0100 Dmytro Maluka wrote: > This limitation will cause (unrelated) events created by modules that > are insmoded after creating the instance to be also added to the > instance. Why not filter those as well? I did think of that. But that would be a separate patch. Where I would save the string that is passed in, and whenever a new module is loaded, it would only add the events if the events' system matches in the string. This would also allow adding event systems that do not yet exist. > > Besides that, the change looks nice to me. Thanks, I'll make it into a more formal patch set. -- Steve