From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4B96A34F for ; Tue, 5 Dec 2023 18:28:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7601AC433C7; Tue, 5 Dec 2023 18:28:21 +0000 (UTC) Date: Tue, 5 Dec 2023 13:28:47 -0500 From: Steven Rostedt To: Dmytro Maluka Cc: LKML , Linux Trace Kernel , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Sean Paul , Arun Easi , Daniel Wagner Subject: Re: [PATCH] tracing: Allow creating instances with specified system events Message-ID: <20231205132847.74d31532@gandalf.local.home> In-Reply-To: References: <20231128122117.2276f4a7@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 5 Dec 2023 19:13:09 +0100 Dmytro Maluka wrote: > On Tue, Nov 28, 2023 at 12:21:17PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > A trace instance may only need to enable specific events. As the eventfs > > directory of an instance currently creates all events which adds overhead, > > allow internal instances to be created with just the events in systems > > that they care about. This currently only deals with systems and not > > individual events, but this should bring down the overhead of creating > > instances for specific use cases quite bit. > > > > The trace_array_get_by_name() now has another parameter "systems". This > > parameter is a const string pointer of a comma/space separated list of > > event systems that should be created by the trace_array. (Note if the > > trace_array already exists, this parameter is ignored). > > > > The list of systems is saved and if a module is loaded, its events will > > not be added unless the system for those events also match the systems > > string. > > > > Note that all dynamic events are still added as they are created by the > > user. > > > > Signed-off-by: Steven Rostedt (Google) > > --- > > Tested-by: Dmytro Maluka Thanks, but I have a v2 of this patch on my local repository, as after discussing with Masami, I decided not to allow dynamic events unless they are specified. I'll send the v2 out later today. -- Steve