Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] ring-buffer: Add offset of events in dump on mismatch
Date: Thu, 7 Dec 2023 17:27:52 -0500	[thread overview]
Message-ID: <20231207172752.01ec634c@gandalf.local.home> (raw)
In-Reply-To: <866d40a8-4e0c-465c-ab8c-b5d864c1a668@efficios.com>

On Thu, 7 Dec 2023 17:19:24 -0500
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> On 2023-12-07 17:16, Steven Rostedt wrote:
> 
> [...]
> 
> > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> > index 8d2a4f00eca9..b10deb8a5647 100644
> > --- a/kernel/trace/ring_buffer.c
> > +++ b/kernel/trace/ring_buffer.c
> > @@ -3424,23 +3424,27 @@ static void dump_buffer_page(struct buffer_data_page *bpage,
> >   		case RINGBUF_TYPE_TIME_EXTEND:
> >   			delta = rb_event_time_stamp(event);
> >   			ts += delta;
> > -			pr_warn("  [%lld] delta:%lld TIME EXTEND\n", ts, delta);
> > +			pr_warn(" %x: [%lld] delta:%lld TIME EXTEND\n",  
> 
> Please prefix hex values with "0x", as in:
> 
> pr_warn(" 0x%x: [%lld] delta:%lld TIME EXTEND\n"
> 
> Otherwise it can be confusing.
> 

Heh, sure. I'm so use to looking at hex for the ring buffer offsets, that I
seldom add the 0x in my debug anymore. But as this is permanent, and not
just a one off print, I'll make the update and post a v2.

Thanks,

-- Steve


      reply	other threads:[~2023-12-07 22:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 22:16 [PATCH] ring-buffer: Add offset of events in dump on mismatch Steven Rostedt
2023-12-07 22:19 ` Mathieu Desnoyers
2023-12-07 22:27   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207172752.01ec634c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox