From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] tracing: Have large events show up as '[LINE TOO BIG]' instead of nothing
Date: Sun, 10 Dec 2023 10:34:15 -0500 [thread overview]
Message-ID: <20231210103415.5afd45ca@gandalf.local.home> (raw)
In-Reply-To: <18d6a5e5-f7a5-4a86-aa0b-eec38652c0d5@efficios.com>
On Sun, 10 Dec 2023 09:11:40 -0500
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> On 2023-12-09 17:10, Steven Rostedt wrote:
> [...]
> > <...>-852 [001] ..... 121.550551: tracing_mark_write[LINE TOO BIG]
> > <...>-852 [001] ..... 121.550581: tracing_mark_write: 78901234
>
> Failing to print an entire message because it does not fit in the
> buffer size is rather inconvenient.
Yes I agree, and luckily it hasn't been called out as an issue. Note, I hit
this because I extended the trace_marker buffer before increasing the
trace_seq size. Otherwise, the trace_marker just breaks it up. This can now
only be triggered by internal changes.
>
> It would be better to print the partial line, and end the line with
> a <TRUNCATED LINE> tag.
Agreed, but I don't have time to do that (I already spent way too much time
on this than I had allocated). I decided to just do what the trace_pipe
currently does, and leave "print partial line" to another day when I can
allocate time on this.
Hmm, this could be added to the "TODO" list that was talked about in
ksummit-discuss.
-- Steve
next prev parent reply other threads:[~2023-12-10 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 22:10 [PATCH] tracing: Have large events show up as '[LINE TOO BIG]' instead of nothing Steven Rostedt
2023-12-10 14:11 ` Mathieu Desnoyers
2023-12-10 15:34 ` Steven Rostedt [this message]
2023-12-11 12:08 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231210103415.5afd45ca@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).