From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v2] ring-buffer: Add offset of events in dump on mismatch
Date: Mon, 11 Dec 2023 13:07:19 -0500 [thread overview]
Message-ID: <20231211130719.771cb5ed@gandalf.local.home> (raw)
In-Reply-To: <20231211130614.43ff4462@gandalf.local.home>
On Mon, 11 Dec 2023 13:06:14 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
>
> case RINGBUF_TYPE_DATA:
> ts += event->time_delta;
> - pr_warn(" [%lld] delta:%d\n", ts, event->time_delta);
> + pr_warn(" 0x%x: [%lld] delta:%d\n",
> + e, ts, event->time_delta);
> break;
>
> default:
> break;
> }
> }
> + pr_warn("expected end:%ld last event actually ended at:%d\n", tail, e);
> }
>
Bah, all offsets were in hex, the above was supposed to be in hex too. I
sent out the wrong version.
Will send a v3 with that update.
-- Steve
next prev parent reply other threads:[~2023-12-11 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 18:06 [PATCH v2] ring-buffer: Add offset of events in dump on mismatch Steven Rostedt
2023-12-11 18:07 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-07 22:31 Steven Rostedt
2023-12-08 11:07 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211130719.771cb5ed@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox