From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C7304A19; Thu, 21 Dec 2023 01:56:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAE92C433C9; Thu, 21 Dec 2023 01:56:03 +0000 (UTC) Date: Wed, 20 Dec 2023 20:57:05 -0500 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Mathieu Desnoyers , Andrew Morton , Tzvetomir Stoyanov , Vincent Donnefort , Kent Overstreet Subject: Re: [PATCH v5 15/15] tracing: Update subbuffer with kilobytes not page order Message-ID: <20231220205705.64de0424@gandalf.local.home> In-Reply-To: <20231221092621.c3d4ecc23b852d3c4183370d@kernel.org> References: <20231219185414.474197117@goodmis.org> <20231219185631.809766769@goodmis.org> <20231221092621.c3d4ecc23b852d3c4183370d@kernel.org> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 Dec 2023 09:26:21 +0900 Masami Hiramatsu (Google) wrote: > > If the user specifies 3 via: > > > > echo 3 > buffer_subbuf_size_kb > > > > Then the sub-buffer size will round up to 4kb (on a 4kb page size system). > > > > If they specify: > > > > echo 6 > buffer_subbuf_size_kb > > > > The sub-buffer size will become 8kb. > > I think this is better interface. Can we apply this earlier in the series > to avoid rewriting the document and test code? I kept it separate for testing purposes. Through out all this, it was a good way to make sure the two approaches were compatible. I still like to keep them separate as that's the way it was developed. It's good to keep that history. -- Steve