From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Naik, Avadhut" <avadnaik@amd.com>,
Tony Luck <tony.luck@intel.com>,
Avadhut Naik <avadhut.naik@amd.com>,
linux-trace-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
yazen.ghannam@amd.com
Subject: Re: [PATCH] tracing: Include PPIN in mce_record tracepoint
Date: Wed, 24 Jan 2024 09:09:08 -0500 [thread overview]
Message-ID: <20240124090908.1c4daea8@rorschach.local.home> (raw)
In-Reply-To: <20240124095708.GAZbDe9Hks0tL2Aj94@fat_crate.local>
On Wed, 24 Jan 2024 10:57:08 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Tue, Jan 23, 2024 at 08:38:53PM -0500, Steven Rostedt wrote:
> > Yes, rasdaemon uses libtraceevent (or a copy of it internally) that
> > reads the format file to find fields. You can safely add fields to the
> > middle of the event structure and the parsing will be just fine.
>
> Should we worry about tools who consume the event "blindly", without the
> lib?
I don't think that's a worry anymore. The offsets can change based on
kernel config. PowerTop needed to have the library ported to it because
it use to hardcode the offsets but then it broke when running the 32bit
version on a 64bit kernel.
>
> I guess no until we break some use case and then we will have to revert.
> At least this is what we've done in the past...
>
But that revert was reverted when we converted PowerTop to use libtraceevent.
-- Steve
next prev parent reply other threads:[~2024-01-24 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 23:51 [PATCH] tracing: Include PPIN in mce_record tracepoint Avadhut Naik
2024-01-24 0:12 ` Tony Luck
2024-01-24 1:29 ` Naik, Avadhut
2024-01-24 1:38 ` Steven Rostedt
2024-01-24 9:57 ` Borislav Petkov
2024-01-24 14:09 ` Steven Rostedt [this message]
2024-01-25 18:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124090908.1c4daea8@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).