From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853A54F5ED; Mon, 29 Jan 2024 22:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706568444; cv=none; b=dvfMK4Ji5p7cTGi8I+u0SIM+UqLTX3rDQx9YIFlrPxQjtWV10laFjuUXzbM/lGf5dIMqg2Fjo4xLX+WIXJ4faaQrzFbS8GKH+x2TmbnmRakBg81xx9fxmZxGBj2gDR68Z40WLnTQA0olIpAGP54RcWDHb4Rht0xpzU+mnViB0C0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706568444; c=relaxed/simple; bh=R4OVOUbiceKRowUYWDKLn08CPB0ttMYSVtdFdQCnOuE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Wc0SysI0NyRZGGPWRn9dlsT2Me/OrHO2gBmqnIeV5EvaQiW7vLIziM0VhZBHtzbTMAiYF2dUOYe1XEUvd1KXJexmTFpyNicXLZQnytr07TWtlFspOnHWeI2XJXITpHwaak5s5wewykZvASetJreAFP4Du+6qpfdDLh+bpYtzG2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B54F9C433C7; Mon, 29 Jan 2024 22:47:22 +0000 (UTC) Date: Mon, 29 Jan 2024 17:47:32 -0500 From: Steven Rostedt To: Linus Torvalds Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Christian Brauner , Al Viro , Ajay Kaher , linux-trace-kernel@vger.kernel.org Subject: Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address Message-ID: <20240129174732.1cea0d69@gandalf.local.home> In-Reply-To: References: <202401291043.e62e89dc-oliver.sang@intel.com> <20240129120125.605e97af@gandalf.local.home> <20240129152600.7587d1aa@gandalf.local.home> <20240129172200.1725f01b@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 29 Jan 2024 14:35:37 -0800 Linus Torvalds wrote: > And I hope there aren't any other stupid things I missed like that. Well the preliminary tests pass with this added to your patch: diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index cd6de3244442..ad11063bdd53 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -230,7 +230,6 @@ static struct eventfs_inode *eventfs_find_events(struct dentry *dentry) { struct eventfs_inode *ei; - mutex_lock(&eventfs_mutex); do { // The parent is stable because we do not do renames dentry = dentry->d_parent; @@ -247,7 +246,6 @@ static struct eventfs_inode *eventfs_find_events(struct dentry *dentry) } // Walk upwards until you find the events inode } while (!ei->is_events); - mutex_unlock(&eventfs_mutex); update_top_events_attr(ei, dentry->d_sb); @@ -324,7 +322,7 @@ static struct dentry *lookup_file(struct dentry *dentry, ti->flags = TRACEFS_EVENT_INODE; ti->private = NULL; // Directories have 'ei', files not - d_instantiate(dentry, inode); + d_add(dentry, inode); fsnotify_create(dentry->d_parent->d_inode, dentry); return eventfs_end_creating(dentry); }; @@ -365,7 +363,7 @@ static struct dentry *lookup_dir_entry(struct dentry *dentry, ei->dentry = dentry; // Remove me! inc_nlink(inode); - d_instantiate(dentry, inode); + d_add(dentry, inode); inc_nlink(dentry->d_parent->d_inode); fsnotify_mkdir(dentry->d_parent->d_inode, dentry); return eventfs_end_creating(dentry); -- Steve