From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4E771292E1; Fri, 16 Feb 2024 13:09:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708088949; cv=none; b=auhNdDsQc0VC1XRU4aHjl4raxGeL1GgrbuCNVUzPXIlzoUWfGZPIgmxhG8ZhUpNWRvyS7PITMquICDnJNPkJlDBpSzHJ68qKPnXCou23lMHBwwPp4n8hqeTS3Yb5OgrmKgP7euaF0Tmqq+8HEIFxYVQ3fMl/f3qo7fHOPk5AJ7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708088949; c=relaxed/simple; bh=l8eCqc2JVcjsz5LHB1HzzSEipUgWfbwHM1DKBGV0Mag=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=myjqY+1jOj3nFtpsvt4jmq0ZNXBrEjN9wFaKdf1BHg3SD64qyaV+myzWuM5plOnQ7N99EI7GwHgW32V9cZm6lLsTviQS0sTpIqGjUlcsr5/KG5OtnoNMMQen3+6ybiS/gvbscY2qPmrpj6J7jmXTsCEBlfLMdN8e2D3Mv/1JnV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L7rZNJaT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L7rZNJaT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 290ECC433F1; Fri, 16 Feb 2024 13:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708088949; bh=l8eCqc2JVcjsz5LHB1HzzSEipUgWfbwHM1DKBGV0Mag=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L7rZNJaT0LSM48DjcsT2GoEPR/VxZh5AiCWZsMQoROcsVrSQyPnv/YPtg+i+51AWS Q5gThd7KO8qcfOoycu35RaSknWOG0wcTwssxGAizMh+Wt7zSakSZ1YSd9F04qIzcye Wc8N+rFTfLtDdseI9FiHNjCf7q7rRLgAida3qAOFuvExSI7xd9FUqnYUEOJ5C0G+Oz /Z4398F/UG2VAiWkFaqlxTHXCWdD5Zyx0qjTpzOlo7RobwFzS5Gfg5SS+JFu/Pabys 8itdtPqRv1l6iE3aQcUX0XiIU5GNQ55naTLylwXA+TMKroB9CQRcXDolCY/b7gKeJy YHesa2RASoMFw== Date: Fri, 16 Feb 2024 22:09:02 +0900 From: Masami Hiramatsu (Google) To: Steven Rostedt Cc: Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Sven Schnelle , Alexei Starovoitov , Jiri Olsa , Arnaldo Carvalho de Melo , Daniel Borkmann , Alan Maguire , Mark Rutland , Peter Zijlstra , Thomas Gleixner , Guo Ren Subject: Re: [PATCH v7 28/36] tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs Message-Id: <20240216220902.a3e017e72273c7894bfe6b16@kernel.org> In-Reply-To: <20240215111134.7bfd1408@gandalf.local.home> References: <170723204881.502590.11906735097521170661.stgit@devnote2> <170723236068.502590.9568421023325291255.stgit@devnote2> <20240215111134.7bfd1408@gandalf.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 15 Feb 2024 11:11:34 -0500 Steven Rostedt wrote: > On Wed, 7 Feb 2024 00:12:40 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Google) > > > > Add ftrace_partial_regs() which converts the ftrace_regs to pt_regs. > > If the architecture defines its own ftrace_regs, this copies partial > > registers to pt_regs and returns it. If not, ftrace_regs is the same as > > pt_regs and ftrace_partial_regs() will return ftrace_regs::regs. > > This says what this patch is doing and not why it is doing it. Hmm, OK. The reason is the eBPF needs this to keep the same pt_regs interface to access registers. Thus when replacing the pt_regs with ftrace_regs in fprobes (which is used by kprobe_multi eBPF event), this will be required. I'll add this to next version. Thanks, > > -- Steve > > > > > Signed-off-by: Masami Hiramatsu (Google) > > Acked-by: Florent Revest > > --- > > Changes from previous series: NOTHING, just forward ported. > > --- -- Masami Hiramatsu (Google)