From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
Vincent Donnefort <vdonnefort@google.com>,
Sven Schnelle <svens@linux.ibm.com>,
Mete Durlu <meted@linux.ibm.com>
Subject: [PATCH v4 0/3] tracing: Changes to saved_cmdlines
Date: Tue, 20 Feb 2024 09:06:13 -0500 [thread overview]
Message-ID: <20240220140613.782679360@goodmis.org> (raw)
The first patch is to consolidate the map_cmdline_to_pid into the allocate
page for the saved_cmdlines structure.
The second patch removes some open coded saved_cmdlines logic in trace.c
into a helper function to make it a cleaner move.
The third patch simply moves code around. The goal is to keep all the
saved_cmdlines logic in one place. Currently it's in two files (trace.c and
trace_sched_switch.c). Since trace.c is awfully large, move all the code to
trace_sched_switch.c, as that's its only purpose today anyway.
Changes since v3: https://lore.kernel.org/linux-trace-kernel/20240216210047.584712062@goodmis.org/
- The map_cmdline_to_pid field was moved into the pages allocated of the
structure and that replaced the kmalloc. But that field still had
kfree() called on it in the freeing of the structure which caused
a memory corruption.
Steven Rostedt (Google) (3):
tracing: Have saved_cmdlines arrays all in one allocation
tracing: Move open coded processing of tgid_map into helper function
tracing: Move saved_cmdline code into trace_sched_switch.c
----
kernel/trace/trace.c | 509 +------------------------------------
kernel/trace/trace.h | 10 +
kernel/trace/trace_sched_switch.c | 515 ++++++++++++++++++++++++++++++++++++++
3 files changed, 528 insertions(+), 506 deletions(-)
next reply other threads:[~2024-02-20 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 14:06 Steven Rostedt [this message]
2024-02-20 14:06 ` [PATCH v4 1/3] tracing: Have saved_cmdlines arrays all in one allocation Steven Rostedt
2024-02-20 14:06 ` [PATCH v4 2/3] tracing: Move open coded processing of tgid_map into helper function Steven Rostedt
2024-02-20 14:06 ` [PATCH v4 3/3] tracing: Move saved_cmdline code into trace_sched_switch.c Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220140613.782679360@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=meted@linux.ibm.com \
--cc=mhiramat@kernel.org \
--cc=svens@linux.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).