* [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping
@ 2024-02-18 8:43 Krishna chaitanya chundru
2024-02-21 6:11 ` Manivannan Sadhasivam
2024-02-22 5:16 ` Manivannan Sadhasivam
0 siblings, 2 replies; 5+ messages in thread
From: Krishna chaitanya chundru @ 2024-02-18 8:43 UTC (permalink / raw)
To: Manivannan Sadhasivam, Steven Rostedt
Cc: linux-kernel, mhi, linux-kernel, linux-arm-msm,
linux-trace-kernel, linux-trace-kernel, quic_vbadigan,
quic_ramkri, quic_nitegupt, quic_skananth, quic_parass,
Krishna chaitanya chundru
User space tools can't map strings if we use directly, as the string
address is internal to kernel.
So add trace point strings for the user space tools to map strings
properly.
Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
---
drivers/bus/mhi/host/main.c | 4 ++--
drivers/bus/mhi/host/trace.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
index 2d38f6005da6..15d657af9b5b 100644
--- a/drivers/bus/mhi/host/main.c
+++ b/drivers/bus/mhi/host/main.c
@@ -1340,7 +1340,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
enum mhi_cmd_type cmd = MHI_CMD_NOP;
int ret;
- trace_mhi_channel_command_start(mhi_cntrl, mhi_chan, to_state, "Updating");
+ trace_mhi_channel_command_start(mhi_cntrl, mhi_chan, to_state, TPS("Updating"));
switch (to_state) {
case MHI_CH_STATE_TYPE_RESET:
write_lock_irq(&mhi_chan->lock);
@@ -1407,7 +1407,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
write_unlock_irq(&mhi_chan->lock);
}
- trace_mhi_channel_command_end(mhi_cntrl, mhi_chan, to_state, "Updated");
+ trace_mhi_channel_command_end(mhi_cntrl, mhi_chan, to_state, TPS("Updated"));
exit_channel_update:
mhi_cntrl->runtime_put(mhi_cntrl);
mhi_device_put(mhi_cntrl->mhi_dev);
diff --git a/drivers/bus/mhi/host/trace.h b/drivers/bus/mhi/host/trace.h
index d12a98d44272..368515dcb22d 100644
--- a/drivers/bus/mhi/host/trace.h
+++ b/drivers/bus/mhi/host/trace.h
@@ -84,6 +84,8 @@ DEV_ST_TRANSITION_LIST
#define dev_st_trans(a, b) { DEV_ST_TRANSITION_##a, b },
#define dev_st_trans_end(a, b) { DEV_ST_TRANSITION_##a, b }
+#define TPS(x) tracepoint_string(x)
+
TRACE_EVENT(mhi_gen_tre,
TP_PROTO(struct mhi_controller *mhi_cntrl, struct mhi_chan *mhi_chan,
---
base-commit: ceeb64f41fe6a1eb9fc56d583983a81f8f3dd058
change-id: 20240218-ftrace_string-7677762aa63c
Best regards,
--
Krishna chaitanya chundru <quic_krichai@quicinc.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping
2024-02-18 8:43 [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping Krishna chaitanya chundru
@ 2024-02-21 6:11 ` Manivannan Sadhasivam
2024-02-21 14:11 ` Steven Rostedt
2024-02-22 5:16 ` Manivannan Sadhasivam
1 sibling, 1 reply; 5+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-21 6:11 UTC (permalink / raw)
To: Krishna chaitanya chundru
Cc: Steven Rostedt, linux-kernel, mhi, linux-arm-msm,
linux-trace-kernel, quic_vbadigan, quic_ramkri, quic_nitegupt,
quic_skananth, quic_parass
On Sun, Feb 18, 2024 at 02:13:39PM +0530, Krishna chaitanya chundru wrote:
> User space tools can't map strings if we use directly, as the string
> address is internal to kernel.
>
> So add trace point strings for the user space tools to map strings
> properly.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/bus/mhi/host/main.c | 4 ++--
> drivers/bus/mhi/host/trace.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index 2d38f6005da6..15d657af9b5b 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -1340,7 +1340,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
> enum mhi_cmd_type cmd = MHI_CMD_NOP;
> int ret;
>
> - trace_mhi_channel_command_start(mhi_cntrl, mhi_chan, to_state, "Updating");
> + trace_mhi_channel_command_start(mhi_cntrl, mhi_chan, to_state, TPS("Updating"));
> switch (to_state) {
> case MHI_CH_STATE_TYPE_RESET:
> write_lock_irq(&mhi_chan->lock);
> @@ -1407,7 +1407,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
> write_unlock_irq(&mhi_chan->lock);
> }
>
> - trace_mhi_channel_command_end(mhi_cntrl, mhi_chan, to_state, "Updated");
> + trace_mhi_channel_command_end(mhi_cntrl, mhi_chan, to_state, TPS("Updated"));
> exit_channel_update:
> mhi_cntrl->runtime_put(mhi_cntrl);
> mhi_device_put(mhi_cntrl->mhi_dev);
> diff --git a/drivers/bus/mhi/host/trace.h b/drivers/bus/mhi/host/trace.h
> index d12a98d44272..368515dcb22d 100644
> --- a/drivers/bus/mhi/host/trace.h
> +++ b/drivers/bus/mhi/host/trace.h
> @@ -84,6 +84,8 @@ DEV_ST_TRANSITION_LIST
> #define dev_st_trans(a, b) { DEV_ST_TRANSITION_##a, b },
> #define dev_st_trans_end(a, b) { DEV_ST_TRANSITION_##a, b }
>
> +#define TPS(x) tracepoint_string(x)
> +
> TRACE_EVENT(mhi_gen_tre,
>
> TP_PROTO(struct mhi_controller *mhi_cntrl, struct mhi_chan *mhi_chan,
>
> ---
> base-commit: ceeb64f41fe6a1eb9fc56d583983a81f8f3dd058
> change-id: 20240218-ftrace_string-7677762aa63c
>
> Best regards,
> --
> Krishna chaitanya chundru <quic_krichai@quicinc.com>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping
2024-02-21 6:11 ` Manivannan Sadhasivam
@ 2024-02-21 14:11 ` Steven Rostedt
2024-02-22 5:14 ` Manivannan Sadhasivam
0 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2024-02-21 14:11 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Krishna chaitanya chundru, linux-kernel, mhi, linux-arm-msm,
linux-trace-kernel, quic_vbadigan, quic_ramkri, quic_nitegupt,
quic_skananth, quic_parass
On Wed, 21 Feb 2024 11:41:46 +0530
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> On Sun, Feb 18, 2024 at 02:13:39PM +0530, Krishna chaitanya chundru wrote:
> > User space tools can't map strings if we use directly, as the string
> > address is internal to kernel.
> >
> > So add trace point strings for the user space tools to map strings
> > properly.
> >
> > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
Suggested-by: may be more accurate?
-- Steve
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping
2024-02-21 14:11 ` Steven Rostedt
@ 2024-02-22 5:14 ` Manivannan Sadhasivam
0 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-22 5:14 UTC (permalink / raw)
To: Steven Rostedt
Cc: Krishna chaitanya chundru, linux-kernel, mhi, linux-arm-msm,
linux-trace-kernel, quic_vbadigan, quic_ramkri, quic_nitegupt,
quic_skananth, quic_parass
On Wed, Feb 21, 2024 at 09:11:03AM -0500, Steven Rostedt wrote:
> On Wed, 21 Feb 2024 11:41:46 +0530
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>
> > On Sun, Feb 18, 2024 at 02:13:39PM +0530, Krishna chaitanya chundru wrote:
> > > User space tools can't map strings if we use directly, as the string
> > > address is internal to kernel.
> > >
> > > So add trace point strings for the user space tools to map strings
> > > properly.
> > >
> > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> >
> > Reported-by: Steven Rostedt <rostedt@goodmis.org>
>
> Suggested-by: may be more accurate?
>
Sure. Will change it while applying.
- Mani
> -- Steve
>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping
2024-02-18 8:43 [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping Krishna chaitanya chundru
2024-02-21 6:11 ` Manivannan Sadhasivam
@ 2024-02-22 5:16 ` Manivannan Sadhasivam
1 sibling, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-22 5:16 UTC (permalink / raw)
To: Krishna chaitanya chundru
Cc: Steven Rostedt, linux-kernel, mhi, linux-arm-msm,
linux-trace-kernel, quic_vbadigan, quic_ramkri, quic_nitegupt,
quic_skananth, quic_parass
On Sun, Feb 18, 2024 at 02:13:39PM +0530, Krishna chaitanya chundru wrote:
> User space tools can't map strings if we use directly, as the string
> address is internal to kernel.
>
> So add trace point strings for the user space tools to map strings
> properly.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
Applied to mhi-next!
- Mani
> ---
> drivers/bus/mhi/host/main.c | 4 ++--
> drivers/bus/mhi/host/trace.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index 2d38f6005da6..15d657af9b5b 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -1340,7 +1340,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
> enum mhi_cmd_type cmd = MHI_CMD_NOP;
> int ret;
>
> - trace_mhi_channel_command_start(mhi_cntrl, mhi_chan, to_state, "Updating");
> + trace_mhi_channel_command_start(mhi_cntrl, mhi_chan, to_state, TPS("Updating"));
> switch (to_state) {
> case MHI_CH_STATE_TYPE_RESET:
> write_lock_irq(&mhi_chan->lock);
> @@ -1407,7 +1407,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
> write_unlock_irq(&mhi_chan->lock);
> }
>
> - trace_mhi_channel_command_end(mhi_cntrl, mhi_chan, to_state, "Updated");
> + trace_mhi_channel_command_end(mhi_cntrl, mhi_chan, to_state, TPS("Updated"));
> exit_channel_update:
> mhi_cntrl->runtime_put(mhi_cntrl);
> mhi_device_put(mhi_cntrl->mhi_dev);
> diff --git a/drivers/bus/mhi/host/trace.h b/drivers/bus/mhi/host/trace.h
> index d12a98d44272..368515dcb22d 100644
> --- a/drivers/bus/mhi/host/trace.h
> +++ b/drivers/bus/mhi/host/trace.h
> @@ -84,6 +84,8 @@ DEV_ST_TRANSITION_LIST
> #define dev_st_trans(a, b) { DEV_ST_TRANSITION_##a, b },
> #define dev_st_trans_end(a, b) { DEV_ST_TRANSITION_##a, b }
>
> +#define TPS(x) tracepoint_string(x)
> +
> TRACE_EVENT(mhi_gen_tre,
>
> TP_PROTO(struct mhi_controller *mhi_cntrl, struct mhi_chan *mhi_chan,
>
> ---
> base-commit: ceeb64f41fe6a1eb9fc56d583983a81f8f3dd058
> change-id: 20240218-ftrace_string-7677762aa63c
>
> Best regards,
> --
> Krishna chaitanya chundru <quic_krichai@quicinc.com>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-22 5:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-18 8:43 [PATCH] bus: mhi: host: Change the trace string for the userspace tools mapping Krishna chaitanya chundru
2024-02-21 6:11 ` Manivannan Sadhasivam
2024-02-21 14:11 ` Steven Rostedt
2024-02-22 5:14 ` Manivannan Sadhasivam
2024-02-22 5:16 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).