From: Jason Xing <kerneljasonxing@gmail.com>
To: edumazet@google.com, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, rostedt@goodmis.org
Cc: netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
kerneljasonxing@gmail.com, Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next 1/2] tcp: add tracing of skb/skaddr in tcp_event_sk_skb class
Date: Fri, 1 Mar 2024 01:09:55 +0800 [thread overview]
Message-ID: <20240229170956.87290-2-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240229170956.87290-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
Prio to this patch, the trace function doesn't print addresses
which might be forgotten. As we can see, it already fetches
those, use it directly and it will print like below:
...tcp_retransmit_skb: skbaddr=XXX skaddr=XXX family=AF_INET...
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
include/trace/events/tcp.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 7b1ddffa3dfc..ac36067ae066 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -88,7 +88,8 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
),
- TP_printk("family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
+ TP_printk("skbaddr=%p skaddr=%p family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
+ __entry->skbaddr, __entry->skaddr,
show_family_name(__entry->family),
__entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
__entry->saddr_v6, __entry->daddr_v6,
--
2.37.3
next prev parent reply other threads:[~2024-02-29 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 17:09 [PATCH net-next 0/2] add two missing addresses when using trace Jason Xing
2024-02-29 17:09 ` Jason Xing [this message]
2024-03-04 8:24 ` [PATCH net-next 1/2] tcp: add tracing of skb/skaddr in tcp_event_sk_skb class Eric Dumazet
2024-03-04 8:31 ` Jason Xing
2024-02-29 17:09 ` [PATCH net-next 2/2] tcp: add tracing of skbaddr in tcp_event_skb class Jason Xing
2024-03-04 7:00 ` [PATCH net-next 0/2] add two missing addresses when using trace Jason Xing
2024-03-04 8:21 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229170956.87290-2-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=edumazet@google.com \
--cc=kernelxing@tencent.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).