From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14211F94B; Fri, 15 Mar 2024 18:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710529000; cv=none; b=lwjt/Jy0+5dGwPlgG4EZna46I012luTwqQw34f7HS9r7VjkBHA8ICk4WZM//MXiAVMLnKGrmg6HiIt90ICnerwdRB4YvYatBk03GITEXTNDodH1zs/1/ahtybvkEMzqGKxBYLKTEj1sMI0WoArxPcFqDP+D6v+WFJTgKuC1RI/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710529000; c=relaxed/simple; bh=dPjJRTej2L6vDTjZl0tMzl13uN4xNcrNG6FfSYbLkUA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gbgWYu1tQTr+4APJ/Mt1Q7VqBI/xrxObHQ4iPu2FU+Z8q/U27v74OBF7tWuR45t7VIh1XrWHduHq8wzodcMJPGA38BXLBSWQxL1y9AZSz1KnUuAQ8jwNLXDjEa/TKpjdtteVknkVYCNtsTo2ntGPsS+2PYOLWDv9cCFD0MC6Wqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31DA5C433C7; Fri, 15 Mar 2024 18:56:39 +0000 (UTC) Date: Fri, 15 Mar 2024 14:58:52 -0400 From: Steven Rostedt To: Luca Ceresoli Cc: Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Thomas Petazzoni Subject: Re: TP_printk() bug with %c, and more? Message-ID: <20240315145852.46125ac5@gandalf.local.home> In-Reply-To: <20240315190312.2bd6a198@booty> References: <20240315174900.14418f22@booty> <20240315132146.29edf416@gandalf.local.home> <20240315190312.2bd6a198@booty> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 15 Mar 2024 19:03:12 +0100 Luca Ceresoli wrote: > > > > > > I've come across an unexpected behaviour in the kernel tracing > > > infrastructure that looks like a bug, or maybe two. > > > > > > Cc-ing ASoC maintainers for as it appeared using ASoC traces, but it > > > does not look ASoC-specific. > > > > > > It all started when using this trace-cmd sequence on an ARM64 board > > > running a mainline 6.8.0-rc7 kernel: > > > > > > trace-cmd record -e snd_soc_dapm_path ./my-play > > > trace-cmd report > > > > > > While this produces perfectly valid traces for other asoc events, > > > the snd_soc_dapm_path produces: > > > > > > snd_soc_dapm_path: >c<* MIC1_EN <- (direct) <- > > > > > > instead of the expected: > > > > > > snd_soc_dapm_path: *MIC1 <- (direct) <- MIC1_EN > > > > > > The originating macro is: > > > > > > TP_printk("%c%s %s %s %s %s", > > > (int) __entry->path_node && > > > (int) __entry->path_connect ? '*' : ' ', > > > __get_str(wname), DAPM_ARROW(__entry->path_dir), > > > __get_str(pname), DAPM_ARROW(__entry->path_dir), > > > __get_str(pnname)) > > > > > > It appears as if the %c placeholder always produces the three ">c<" > > > characters, the '*' or ' ' char is printed as the first %s, all the > > > other strings are shifted right by one position and the last string is > > > never printed. > > > > > > On my x86_64 laptop running the default Ubuntu kernel (6.5) I'm able to > > > trace a few events having a '%c' in their TP_printk() macros and the > > > result is: > > > > > > intel_pipe_update_start: dev 0000:00:02.0, pipe >c<, frame=1, > > > scanline=107856, min=2208, max=2154 > > > > > > > What does /sys/kernel/tracing/trace show? > > It is correct: > > intel_pipe_update_start: dev 0000:00:02.0, pipe B, frame=377644, scanline=1466, min=2154, max=2159 > > > If that's fine, then the bug is in libtraceevent and not the kernel. > > > > I'm testing it out now, and I see %c not being processed properly by > > libtraceevent. I'll take a deeper look. > > Thanks. > > > > originating from: > > > > > > TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u", > > > > > > Here it looks like the %c produced ">c<" again, but apparently without > > > any shifting. > > > > > > Back on the ARM64 board I found a couple interesting clues. > > > > > > First, using the /tracing/ interface instead of trace-cmd, I'm > > > getting correctly formatted strings: > > > > > > trace-cmd: snd_soc_dapm_path: >c<* HPOUT_L -> (direct) -> > > > debugfs: snd_soc_dapm_path: *HPOUT_L <- (direct) <- HPOUT_POP_SOUND_L > > > > > > Notice the arrows pointing to the opposite direction though. The correct > > > arrow is the one in the debugfs run. > > This other issue appears a separate bug however. Can you make user you have the latest libtraceevent from: git://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git And apply this patch. Thanks, -- Steve diff --git a/src/event-parse.c b/src/event-parse.c index d607556..61b0966 100644 --- a/src/event-parse.c +++ b/src/event-parse.c @@ -3732,8 +3732,19 @@ process_arg_token(struct tep_event *event, struct tep_print_arg *arg, arg->atom.atom = atom; break; - case TEP_EVENT_DQUOTE: case TEP_EVENT_SQUOTE: + arg->type = TEP_PRINT_ATOM; + /* Make characters into numbers */ + if (asprintf(&arg->atom.atom, "%d", token[0]) < 0) { + free_token(token); + *tok = NULL; + arg->atom.atom = NULL; + return TEP_EVENT_ERROR; + } + free_token(token); + type = read_token_item(event->tep, &token); + break; + case TEP_EVENT_DQUOTE: arg->type = TEP_PRINT_ATOM; arg->atom.atom = token; type = read_token_item(event->tep, &token);