* [GIT PULL] tracing/tools: Updates for 6.9
@ 2024-03-18 17:41 Daniel Bristot de Oliveira
2024-03-19 23:02 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Bristot de Oliveira @ 2024-03-18 17:41 UTC (permalink / raw)
To: Steven Rostedt
Cc: Daniel Bristot de Oliveira, Masami Hiramatsu, linux-kernel,
linux-trace-kernel
Steven,
Tracing tooling updates for 6.9
Tracing:
- Update makefiles for latency-collector and RTLA,
using tools/build/ makefiles like perf does, inheriting
its benefits. For example, having a proper way to
handle dependencies.
- The timerlat tracer has an interface for any tool to use.
rtla timerlat tool uses this interface dispatching its
own threads as workload. But, rtla timerlat could also be
used for any other process. So, add 'rtla timerlat -U'
option, allowing the timerlat tool to measure the latency of
any task using the timerlat tracer interface.
Verification:
- Update makefiles for verification/rv, using tools/build/
makefiles like perf does, inheriting its benefits.
For example, having a proper way to handle dependencies.
Please pull the latest trace-tools-v6.9 tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/bristot/linux.git
trace-tools-v6.9
Tag SHA1: 2eb09a97c56af3c27bd9dcebccb495f70d56d5c0
Head SHA1: 9c63d9f58a42b979a42bcaed534d9246996ac0d9
Daniel Bristot de Oliveira (4):
tools/tracing: Use tools/build makefiles on latency-collector
tools/rtla: Use tools/build makefiles to build rtla
tools/verification: Use tools/build makefiles on rv
tools/rtla: Add -U/--user-load option to timerlat
----
.../tools/rtla/common_timerlat_options.rst | 6 +
tools/tracing/latency/.gitignore | 5 +-
tools/tracing/latency/Build | 1 +
tools/tracing/latency/Makefile | 105 ++++++++--
tools/tracing/latency/Makefile.config | 30 +++
tools/tracing/rtla/.gitignore | 7 +-
tools/tracing/rtla/Build | 1 +
tools/tracing/rtla/Makefile | 217 +++++++--------------
tools/tracing/rtla/Makefile.config | 47 +++++
tools/tracing/rtla/Makefile.rtla | 80 ++++++++
tools/tracing/rtla/Makefile.standalone | 26 +++
tools/tracing/rtla/sample/timerlat_load.py | 74 +++++++
tools/tracing/rtla/src/Build | 11 ++
tools/tracing/rtla/src/timerlat_hist.c | 16 +-
tools/tracing/rtla/src/timerlat_top.c | 14 +-
tools/verification/rv/.gitignore | 6 +
tools/verification/rv/Build | 1 +
tools/verification/rv/Makefile | 207 +++++++-------------
tools/verification/rv/Makefile.config | 47 +++++
tools/verification/rv/Makefile.rv | 51 +++++
tools/verification/rv/src/Build | 4 +
21 files changed, 650 insertions(+), 306 deletions(-)
create mode 100644 tools/tracing/latency/Build
create mode 100644 tools/tracing/latency/Makefile.config
create mode 100644 tools/tracing/rtla/Build
create mode 100644 tools/tracing/rtla/Makefile.config
create mode 100644 tools/tracing/rtla/Makefile.rtla
create mode 100644 tools/tracing/rtla/Makefile.standalone
create mode 100644 tools/tracing/rtla/sample/timerlat_load.py
create mode 100644 tools/tracing/rtla/src/Build
create mode 100644 tools/verification/rv/.gitignore
create mode 100644 tools/verification/rv/Build
create mode 100644 tools/verification/rv/Makefile.config
create mode 100644 tools/verification/rv/Makefile.rv
create mode 100644 tools/verification/rv/src/Build
---------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] tracing/tools: Updates for 6.9
2024-03-18 17:41 [GIT PULL] tracing/tools: Updates for 6.9 Daniel Bristot de Oliveira
@ 2024-03-19 23:02 ` Steven Rostedt
2024-03-20 12:41 ` Daniel Bristot de Oliveira
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2024-03-19 23:02 UTC (permalink / raw)
To: Daniel Bristot de Oliveira
Cc: Masami Hiramatsu, linux-kernel, linux-trace-kernel
On Mon, 18 Mar 2024 18:41:13 +0100
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
> Steven,
>
> Tracing tooling updates for 6.9
>
> Tracing:
> - Update makefiles for latency-collector and RTLA,
> using tools/build/ makefiles like perf does, inheriting
> its benefits. For example, having a proper way to
> handle dependencies.
>
> - The timerlat tracer has an interface for any tool to use.
> rtla timerlat tool uses this interface dispatching its
> own threads as workload. But, rtla timerlat could also be
> used for any other process. So, add 'rtla timerlat -U'
> option, allowing the timerlat tool to measure the latency of
> any task using the timerlat tracer interface.
>
> Verification:
> - Update makefiles for verification/rv, using tools/build/
> makefiles like perf does, inheriting its benefits.
> For example, having a proper way to handle dependencies.
>
>
> Please pull the latest trace-tools-v6.9 tree, which can be found at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bristot/linux.git
> trace-tools-v6.9
Looks like you just built on top of a random commit from Linus's tree:
commit f6cef5f8c37f58a3bc95b3754c3ae98e086631ca
Merge: 906a93befec8 8f06fb458539
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun Mar 17 16:59:33 2024 -0700
Merge tag 'i3c/for-6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux
Linus prefers basing off of real tags or previous pulls from us.
Can you rebase your changes on v6.8 and resend?
$ git checkout v6.8
$ git cherry-pick f6cef5f8c37f58a3bc95b3754c3ae98e086631ca..trace-tools-v6.9
Appears to work fine.
Thanks!
-- Steve
>
> Tag SHA1: 2eb09a97c56af3c27bd9dcebccb495f70d56d5c0
> Head SHA1: 9c63d9f58a42b979a42bcaed534d9246996ac0d9
>
>
> Daniel Bristot de Oliveira (4):
> tools/tracing: Use tools/build makefiles on latency-collector
> tools/rtla: Use tools/build makefiles to build rtla
> tools/verification: Use tools/build makefiles on rv
> tools/rtla: Add -U/--user-load option to timerlat
>
> ----
> .../tools/rtla/common_timerlat_options.rst | 6 +
> tools/tracing/latency/.gitignore | 5 +-
> tools/tracing/latency/Build | 1 +
> tools/tracing/latency/Makefile | 105 ++++++++--
> tools/tracing/latency/Makefile.config | 30 +++
> tools/tracing/rtla/.gitignore | 7 +-
> tools/tracing/rtla/Build | 1 +
> tools/tracing/rtla/Makefile | 217 +++++++--------------
> tools/tracing/rtla/Makefile.config | 47 +++++
> tools/tracing/rtla/Makefile.rtla | 80 ++++++++
> tools/tracing/rtla/Makefile.standalone | 26 +++
> tools/tracing/rtla/sample/timerlat_load.py | 74 +++++++
> tools/tracing/rtla/src/Build | 11 ++
> tools/tracing/rtla/src/timerlat_hist.c | 16 +-
> tools/tracing/rtla/src/timerlat_top.c | 14 +-
> tools/verification/rv/.gitignore | 6 +
> tools/verification/rv/Build | 1 +
> tools/verification/rv/Makefile | 207 +++++++-------------
> tools/verification/rv/Makefile.config | 47 +++++
> tools/verification/rv/Makefile.rv | 51 +++++
> tools/verification/rv/src/Build | 4 +
> 21 files changed, 650 insertions(+), 306 deletions(-)
> create mode 100644 tools/tracing/latency/Build
> create mode 100644 tools/tracing/latency/Makefile.config
> create mode 100644 tools/tracing/rtla/Build
> create mode 100644 tools/tracing/rtla/Makefile.config
> create mode 100644 tools/tracing/rtla/Makefile.rtla
> create mode 100644 tools/tracing/rtla/Makefile.standalone
> create mode 100644 tools/tracing/rtla/sample/timerlat_load.py
> create mode 100644 tools/tracing/rtla/src/Build
> create mode 100644 tools/verification/rv/.gitignore
> create mode 100644 tools/verification/rv/Build
> create mode 100644 tools/verification/rv/Makefile.config
> create mode 100644 tools/verification/rv/Makefile.rv
> create mode 100644 tools/verification/rv/src/Build
> ---------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] tracing/tools: Updates for 6.9
2024-03-19 23:02 ` Steven Rostedt
@ 2024-03-20 12:41 ` Daniel Bristot de Oliveira
2024-03-20 13:29 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Bristot de Oliveira @ 2024-03-20 12:41 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Masami Hiramatsu, linux-kernel, linux-trace-kernel
On 3/20/24 00:02, Steven Rostedt wrote:
> On Mon, 18 Mar 2024 18:41:13 +0100
> Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
>
>> Steven,
>>
>> Tracing tooling updates for 6.9
>>
>> Tracing:
>> - Update makefiles for latency-collector and RTLA,
>> using tools/build/ makefiles like perf does, inheriting
>> its benefits. For example, having a proper way to
>> handle dependencies.
>>
>> - The timerlat tracer has an interface for any tool to use.
>> rtla timerlat tool uses this interface dispatching its
>> own threads as workload. But, rtla timerlat could also be
>> used for any other process. So, add 'rtla timerlat -U'
>> option, allowing the timerlat tool to measure the latency of
>> any task using the timerlat tracer interface.
>>
>> Verification:
>> - Update makefiles for verification/rv, using tools/build/
>> makefiles like perf does, inheriting its benefits.
>> For example, having a proper way to handle dependencies.
>>
>>
>> Please pull the latest trace-tools-v6.9 tree, which can be found at:
>>
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/bristot/linux.git
>> trace-tools-v6.9
>
> Looks like you just built on top of a random commit from Linus's tree:
yeah :-/
> commit f6cef5f8c37f58a3bc95b3754c3ae98e086631ca
> Merge: 906a93befec8 8f06fb458539
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Sun Mar 17 16:59:33 2024 -0700
>
> Merge tag 'i3c/for-6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux
>
> Linus prefers basing off of real tags or previous pulls from us.
Ack, took note. I will do on top v6.8 tag.
> Can you rebase your changes on v6.8 and resend?
>
> $ git checkout v6.8
> $ git cherry-pick f6cef5f8c37f58a3bc95b3754c3ae98e086631ca..trace-tools-v6.9
>
> Appears to work fine.
questions: when something go wrong in a pull request....
- Should I keep the old tag, and then do another one with -2
(it seems you do like this), or delete the old tag and send it again
with the same name?
- Should I resend the PULL request with something in the log or
at the Subject saying it is a v2 of the pull request?
I could ask via chat, but I think it is good for the community to
have access to these info.
Thanks!
-- Daniel
> Thanks!
>
> -- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] tracing/tools: Updates for 6.9
2024-03-20 12:41 ` Daniel Bristot de Oliveira
@ 2024-03-20 13:29 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2024-03-20 13:29 UTC (permalink / raw)
To: Daniel Bristot de Oliveira
Cc: Masami Hiramatsu, linux-kernel, linux-trace-kernel
On Wed, 20 Mar 2024 13:41:12 +0100
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
> On 3/20/24 00:02, Steven Rostedt wrote:
> > On Mon, 18 Mar 2024 18:41:13 +0100
> > Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
> >
> >> Steven,
> >>
> >> Tracing tooling updates for 6.9
> >>
> >> Tracing:
> >> - Update makefiles for latency-collector and RTLA,
> >> using tools/build/ makefiles like perf does, inheriting
> >> its benefits. For example, having a proper way to
> >> handle dependencies.
> >>
> >> - The timerlat tracer has an interface for any tool to use.
> >> rtla timerlat tool uses this interface dispatching its
> >> own threads as workload. But, rtla timerlat could also be
> >> used for any other process. So, add 'rtla timerlat -U'
> >> option, allowing the timerlat tool to measure the latency of
> >> any task using the timerlat tracer interface.
> >>
> >> Verification:
> >> - Update makefiles for verification/rv, using tools/build/
> >> makefiles like perf does, inheriting its benefits.
> >> For example, having a proper way to handle dependencies.
> >>
> >>
> >> Please pull the latest trace-tools-v6.9 tree, which can be found at:
> >>
> >>
> >> git://git.kernel.org/pub/scm/linux/kernel/git/bristot/linux.git
> >> trace-tools-v6.9
> >
> > Looks like you just built on top of a random commit from Linus's tree:
>
> yeah :-/
>
> > commit f6cef5f8c37f58a3bc95b3754c3ae98e086631ca
> > Merge: 906a93befec8 8f06fb458539
> > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > Date: Sun Mar 17 16:59:33 2024 -0700
> >
> > Merge tag 'i3c/for-6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux
> >
> > Linus prefers basing off of real tags or previous pulls from us.
>
> Ack, took note. I will do on top v6.8 tag.
>
> > Can you rebase your changes on v6.8 and resend?
> >
> > $ git checkout v6.8
> > $ git cherry-pick f6cef5f8c37f58a3bc95b3754c3ae98e086631ca..trace-tools-v6.9
> >
> > Appears to work fine.
>
> questions: when something go wrong in a pull request....
>
> - Should I keep the old tag, and then do another one with -2
> (it seems you do like this), or delete the old tag and send it again
> with the same name?
Just create a new tag.
>
> - Should I resend the PULL request with something in the log or
> at the Subject saying it is a v2 of the pull request?
Yes please.
>
> I could ask via chat, but I think it is good for the community to
> have access to these info.
+1
Thanks,
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-20 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-18 17:41 [GIT PULL] tracing/tools: Updates for 6.9 Daniel Bristot de Oliveira
2024-03-19 23:02 ` Steven Rostedt
2024-03-20 12:41 ` Daniel Bristot de Oliveira
2024-03-20 13:29 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox