From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: linux-trace-kernel@vger.kernel.org, rostedt@goodmis.org,
bpf@vger.kernel.org, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org, oleg@redhat.com, jolsa@kernel.org
Subject: Re: [PATCH v2 0/3] uprobes: two common case speed ups
Date: Tue, 19 Mar 2024 13:20:57 +0900 [thread overview]
Message-ID: <20240319132057.78e60d15e4fd07dbef3b14a9@kernel.org> (raw)
In-Reply-To: <20240318181728.2795838-1-andrii@kernel.org>
Hi,
On Mon, 18 Mar 2024 11:17:25 -0700
Andrii Nakryiko <andrii@kernel.org> wrote:
> This patch set implements two speed ups for uprobe/uretprobe runtime execution
> path for some common scenarios: BPF-only uprobes (patches #1 and #2) and
> system-wide (non-PID-specific) uprobes (patch #3). Please see individual
> patches for details.
This series looks good to me. Let me pick it on probes/for-next.
Thanks!
>
> v1->v2:
> - rebased onto trace/core branch of tracing tree, hopefully I guessed right;
> - simplified user_cpu_buffer usage further (Oleg Nesterov);
> - simplified patch #3, just moved speculative check outside of lock (Oleg);
> - added Reviewed-by from Jiri Olsa.
>
> Andrii Nakryiko (3):
> uprobes: encapsulate preparation of uprobe args buffer
> uprobes: prepare uprobe args buffer lazily
> uprobes: add speculative lockless system-wide uprobe filter check
>
> kernel/trace/trace_uprobe.c | 103 +++++++++++++++++++++---------------
> 1 file changed, 59 insertions(+), 44 deletions(-)
>
> --
> 2.43.0
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-03-19 4:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 18:17 [PATCH v2 0/3] uprobes: two common case speed ups Andrii Nakryiko
2024-03-18 18:17 ` [PATCH v2 1/3] uprobes: encapsulate preparation of uprobe args buffer Andrii Nakryiko
2024-03-18 18:17 ` [PATCH v2 2/3] uprobes: prepare uprobe args buffer lazily Andrii Nakryiko
2024-03-18 18:17 ` [PATCH v2 3/3] uprobes: add speculative lockless system-wide uprobe filter check Andrii Nakryiko
2024-03-19 4:20 ` Masami Hiramatsu [this message]
2024-03-19 4:26 ` [PATCH v2 0/3] uprobes: two common case speed ups Masami Hiramatsu
2024-03-19 16:19 ` Andrii Nakryiko
2024-03-20 3:17 ` Masami Hiramatsu
2024-03-19 5:48 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319132057.78e60d15e4fd07dbef3b14a9@kernel.org \
--to=mhiramat@kernel.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).