From: Dhruva Gole <d-gole@ti.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: <linux@armlinux.org.uk>, <catalin.marinas@arm.com>,
<will@kernel.org>, <sudeep.holla@arm.com>, <rafael@kernel.org>,
<viresh.kumar@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<mingo@redhat.com>, <peterz@infradead.org>,
<juri.lelli@redhat.com>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
<bristot@redhat.com>, <vschneid@redhat.com>,
<lukasz.luba@arm.com>, <rui.zhang@intel.com>,
<mhiramat@kernel.org>, <daniel.lezcano@linaro.org>,
<amit.kachhap@gmail.com>, <corbet@lwn.net>,
<gregkh@linuxfoundation.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v6 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure()
Date: Tue, 26 Mar 2024 17:16:51 +0530 [thread overview]
Message-ID: <20240326114651.ibuoa5f7gk57t4if@dhruva> (raw)
In-Reply-To: <20240326091616.3696851-4-vincent.guittot@linaro.org>
Hi,
On Mar 26, 2024 at 10:16:14 +0100, Vincent Guittot wrote:
> arch_update_thermal_pressure() aims to update fast changing signal which
> should be averaged using PELT filtering before being provided to the
> scheduler which can't make smart use of fast changing signal.
> cpufreq now provides the maximum freq_qos pressure on the capacity to the
> scheduler, which includes cpufreq cooling device. Remove the call to
> arch_update_thermal_pressure() in cpufreq cooling device as this is
> handled by cpufreq_get_pressure().
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Tested-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
Makes sense,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Best regards,
Dhruva
next prev parent reply other threads:[~2024-03-26 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 9:16 [PATCH v6 0/5] Rework system pressure interface to the scheduler Vincent Guittot
2024-03-26 9:16 ` [PATCH v6 1/5] cpufreq: Add a cpufreq pressure feedback for " Vincent Guittot
2024-03-26 11:44 ` Dhruva Gole
2024-03-26 9:16 ` [PATCH v6 2/5] sched: Take cpufreq feedback into account Vincent Guittot
2024-03-26 9:16 ` [PATCH v6 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Vincent Guittot
2024-03-26 11:46 ` Dhruva Gole [this message]
2024-03-26 9:16 ` [PATCH v6 4/5] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Vincent Guittot
2024-04-30 11:23 ` Konrad Dybcio
2024-04-30 12:00 ` Vincent Guittot
2024-04-30 12:15 ` Konrad Dybcio
2024-03-26 9:16 ` [PATCH v6 5/5] sched/pelt: Remove shift of thermal clock Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326114651.ibuoa5f7gk57t4if@dhruva \
--to=d-gole@ti.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=andersson@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=juri.lelli@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox