From: Simon Horman <horms@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: edumazet@google.com, dsahern@kernel.org, matttbe@kernel.org,
martineau@kernel.org, geliang@kernel.org, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net, rostedt@goodmis.org,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
atenart@kernel.org, mptcp@lists.linux.dev,
netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v7 1/7] net: introduce rstreason to detect why the RST is sent
Date: Mon, 22 Apr 2024 19:27:55 +0100 [thread overview]
Message-ID: <20240422182755.GD42092@kernel.org> (raw)
In-Reply-To: <20240422030109.12891-2-kerneljasonxing@gmail.com>
On Mon, Apr 22, 2024 at 11:01:03AM +0800, Jason Xing wrote:
...
> diff --git a/include/net/rstreason.h b/include/net/rstreason.h
...
> +/**
> + * There are three parts in order:
> + * 1) reset reason in MPTCP: only for MPTCP use
> + * 2) skb drop reason: relying on drop reasons for such as passive reset
> + * 3) independent reset reason: such as active reset reasons
> + */
Hi Jason,
A minor nit from my side.
'/**' denotes the beginning of a Kernel doc,
but other than that, this comment is not a Kernel doc.
FWIIW, I would suggest providing a proper Kernel doc for enum sk_rst_reason.
But another option would be to simply make this a normal comment,
starting with "/* There are"
> +enum sk_rst_reason {
...
next prev parent reply other threads:[~2024-04-22 18:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 3:01 [PATCH net-next v7 0/7] Implement reset reason mechanism to detect Jason Xing
2024-04-22 3:01 ` [PATCH net-next v7 1/7] net: introduce rstreason to detect why the RST is sent Jason Xing
2024-04-22 8:46 ` Matthieu Baerts
2024-04-22 9:17 ` Jason Xing
2024-04-22 10:05 ` Matthieu Baerts
2024-04-22 18:27 ` Simon Horman [this message]
2024-04-23 2:14 ` Jason Xing
2024-04-23 2:17 ` Jason Xing
2024-04-23 11:57 ` Simon Horman
2024-04-23 12:03 ` Jason Xing
2024-04-22 3:01 ` [PATCH net-next v7 2/7] rstreason: prepare for passive reset Jason Xing
2024-04-22 3:01 ` [PATCH net-next v7 3/7] rstreason: prepare for active reset Jason Xing
2024-04-22 3:01 ` [PATCH net-next v7 4/7] tcp: support rstreason for passive reset Jason Xing
2024-04-22 3:01 ` [PATCH net-next v7 5/7] mptcp: " Jason Xing
2024-04-22 3:01 ` [PATCH net-next v7 6/7] mptcp: introducing a helper into active reset logic Jason Xing
2024-04-22 3:01 ` [PATCH net-next v7 7/7] rstreason: make it work in trace world Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422182755.GD42092@kernel.org \
--to=horms@kernel.org \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matttbe@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).