From: Steven Rostedt <rostedt@goodmis.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: Vincent Donnefort <vdonnefort@google.com>,
mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, kernel-team@android.com,
rdunlap@infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH v20 2/5] ring-buffer: Introducing ring-buffer mapping functions
Date: Sun, 28 Apr 2024 17:24:06 -0400 [thread overview]
Message-ID: <20240428172406.6eda8a17@rorschach.local.home> (raw)
In-Reply-To: <6apbwt27afeercymrjsulrgyv4c2pj2tzqdllukf4czsbfifqo@6p23uqdjqtu7>
On Tue, 23 Apr 2024 12:04:15 -0400
"Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> > Nit: For all labels, please add a space before them. Otherwise, diffs will
> > show "unlock" as the function and not "ring_buffer_map", making it harder
> > to find where the change is.
> >
>
> Isn't the inclusion of a space before labels outdate since 'git diff'
> superseds 'diff' and fixed this issue?
I still use patch and quilt ;-) and that still suffers from that on
reject files (used for backporting and such).
-- Steve
next prev parent reply other threads:[~2024-04-28 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 17:36 [PATCH v20 0/5] Introducing trace buffer mapping by user-space Vincent Donnefort
2024-04-06 17:36 ` [PATCH v20 1/5] ring-buffer: allocate sub-buffers with __GFP_COMP Vincent Donnefort
2024-04-10 17:36 ` Steven Rostedt
2024-04-06 17:36 ` [PATCH v20 2/5] ring-buffer: Introducing ring-buffer mapping functions Vincent Donnefort
2024-04-10 17:43 ` Steven Rostedt
2024-04-23 16:04 ` Liam R. Howlett
2024-04-28 21:24 ` Steven Rostedt [this message]
2024-04-18 6:55 ` Mike Rapoport
2024-04-19 3:43 ` Steven Rostedt
2024-04-22 18:01 ` Vincent Donnefort
2024-04-19 18:25 ` David Hildenbrand
2024-04-22 9:27 ` David Hildenbrand
2024-04-22 18:20 ` Vincent Donnefort
2024-04-22 18:27 ` David Hildenbrand
2024-04-22 20:31 ` Vincent Donnefort
2024-04-23 15:18 ` David Hildenbrand
2024-04-06 17:36 ` [PATCH v20 3/5] tracing: Allow user-space mapping of the ring-buffer Vincent Donnefort
2024-04-06 17:36 ` [PATCH v20 4/5] Documentation: tracing: Add ring-buffer mapping Vincent Donnefort
2024-04-06 17:36 ` [PATCH v20 5/5] ring-buffer/selftest: Add ring-buffer mapping test Vincent Donnefort
2024-04-06 20:46 ` Muhammad Usama Anjum
2024-04-10 17:56 ` [PATCH v20 0/5] Introducing trace buffer mapping by user-space Steven Rostedt
2024-04-17 4:55 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428172406.6eda8a17@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=Liam.Howlett@oracle.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rdunlap@infradead.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).