From: Steven Rostedt <rostedt@goodmis.org>
To: <xu.xin16@zte.com.cn>
Cc: <kuba@kernel.org>, <horms@kernel.org>, <davem@davemloft.net>,
<mhiramat@kernel.org>, <dsahern@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<yang.yang29@zte.com.cn>, <he.peilin@zte.com.cn>,
<liu.chun2@zte.com.cn>, <jiang.xuexin@zte.com.cn>,
<zhang.yunkai@zte.com.cn>, <kerneljasonxing@gmail.com>,
<fan.yu9@zte.com.cn>, <qiu.yutan@zte.com.cn>,
<ran.xiaokai@zte.com.cn>, <zhang.run@zte.com.cn>,
<wang.haoyi@zte.com.cn>, <si.hao@zte.com.cn>,
<lu.zhongjun@zte.com.cn>
Subject: Re: [PATCH net-next v9] net/ipv4: add tracepoint for icmp_send
Date: Tue, 7 May 2024 05:09:17 -0400 [thread overview]
Message-ID: <20240507050917.238a0891@rorschach.local.home> (raw)
In-Reply-To: <202405071541038433DpxXxFl-a_4XcQGTy_BU@zte.com.cn>
On Tue, 7 May 2024 15:41:03 +0800 (CST)
<xu.xin16@zte.com.cn> wrote:
> From: Peilin He <he.peilin@zte.com.cn>
>
> Introduce a tracepoint for icmp_send, which can help users to get more
> detail information conveniently when icmp abnormal events happen.
>
> 1. Giving an usecase example:
> =============================
> When an application experiences packet loss due to an unreachable UDP
> destination port, the kernel will send an exception message through the
> icmp_send function. By adding a trace point for icmp_send, developers or
> system administrators can obtain detailed information about the UDP
> packet loss, including the type, code, source address, destination address,
> source port, and destination port. This facilitates the trouble-shooting
> of UDP packet loss issues especially for those network-service
> applications.
>
> 2. Operation Instructions:
> ==========================
> Switch to the tracing directory.
> cd /sys/kernel/tracing
> Filter for destination port unreachable.
> echo "type==3 && code==3" > events/icmp/icmp_send/filter
> Enable trace event.
> echo 1 > events/icmp/icmp_send/enable
>
> 3. Result View:
> ================
> udp_client_erro-11370 [002] ...s.12 124.728002:
> icmp_send: icmp_send: type=3, code=3.
> From 127.0.0.1:41895 to 127.0.0.1:6666 ulen=23
> skbaddr=00000000589b167a
>
> Signed-off-by: Peilin He <he.peilin@zte.com.cn>
> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
> Reviewed-by: Yunkai Zhang <zhang.yunkai@zte.com.cn>
> Cc: Yang Yang <yang.yang29@zte.com.cn>
> Cc: Liu Chun <liu.chun2@zte.com.cn>
> Cc: Xuexin Jiang <jiang.xuexin@zte.com.cn>
> ---
From just a tracing point of view:
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
prev parent reply other threads:[~2024-05-07 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 7:41 [PATCH net-next v9] net/ipv4: add tracepoint for icmp_send xu.xin16
2024-05-07 9:09 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507050917.238a0891@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=fan.yu9@zte.com.cn \
--cc=he.peilin@zte.com.cn \
--cc=horms@kernel.org \
--cc=jiang.xuexin@zte.com.cn \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=liu.chun2@zte.com.cn \
--cc=lu.zhongjun@zte.com.cn \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qiu.yutan@zte.com.cn \
--cc=ran.xiaokai@zte.com.cn \
--cc=si.hao@zte.com.cn \
--cc=wang.haoyi@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=zhang.run@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox