From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DB3A13174E; Tue, 7 May 2024 23:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715124958; cv=none; b=TWzTtr6wzyuw2K+dvJdHAeZIlqYgEVUThJfnvDHz/jd+R9zSavQb5JeaOJA+gXuT061RKH/uaUO6aNMsSjJJUfBgzQNIoZF1l+9Krq3YZnSNmFKi6CTBJOL+dhgBps8zQbZfE8QUqbJEizmYHovGGjBaBRW7hGi0vMMCjDl6h0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715124958; c=relaxed/simple; bh=gaeDja9fME/KkLtLEpCcfbpv+skEwWy0D4LLH9190n4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Pat2nCg0UeZiUqs8NHH/2VCkGk91QkL1RB1kceF6MpbJ4v4Wa8r62bjnn9COmEvF8LDEM1nxJRlORuhOKQ2g8wezHGMeiI7yQ4BXl1hw+BnG+UZ7r8Fnrf+oyx/cVfxmi3mEfSlqnYUUWOvn1UNFj1rs+f/7M6xzlZ8dXNBKwho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 650B9C2BBFC; Tue, 7 May 2024 23:35:57 +0000 (UTC) Date: Tue, 7 May 2024 19:35:55 -0400 From: Steven Rostedt To: Vincent Donnefort Cc: Shuah Khan , mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, rdunlap@infradead.org, rppt@kernel.org, david@redhat.com, Shuah Khan , linux-kselftest@vger.kernel.org, Muhammad Usama Anjum Subject: Re: [PATCH v22 5/5] ring-buffer/selftest: Add ring-buffer mapping test Message-ID: <20240507193555.592a1e28@rorschach.local.home> In-Reply-To: <5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org> References: <20240430111354.637356-1-vdonnefort@google.com> <20240430111354.637356-6-vdonnefort@google.com> <5bdb08a2-0740-4ea0-be24-a948332d60ac@linuxfoundation.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 3 May 2024 13:12:56 -0600 Shuah Khan wrote: > On 4/30/24 05:13, Vincent Donnefort wrote: > > This test maps a ring-buffer and validate the meta-page after reset and > > after emitting few events. > > > > Changelog needs to be imperative - refer to the following: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Update the change log and describe what the test does and include > test output. > > If the test requires root privileges - make sure add a check to skip > when a normal use runs the test. > > The rest looks good. > Vincent, Can you address Shuah's concerns. I'm starting to test patches 1-4 so you only need to send an update to this one, unless of course I find an issue with one of the others. Thanks, -- Steve