From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 194AD1C27; Sun, 26 May 2024 23:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716765444; cv=none; b=b4ZSd+MKCIrt8aLK343RjiK3/GM50wgM13hzQWEq1IjbsgL4JaQjjj37w8QMrJKTN2YgbhY2+jiYff8/Hbbsm1Q/o4kcVe/OaRAcw9heVY3JPm+xsB8lAux62qPiLEtziOQu1GLWCha9D9zCHULxZn+GZ5tFP9oW4K1ttk0OFSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716765444; c=relaxed/simple; bh=lqV71dyGNzoKcV/Iv3TfEMBsKD/L3s54JM57KtyVYmo=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Nny6eokHVuYQ9c5fLZD9WjXop6+s0byi4h3tCZhEopsbV2w0FOMX3UwVZmoEBZvZYhhNJqR20leDeicz1xoqq7QsopujssYmZ3K6plrct7zx2IQdUx2aEsf4ipr4dK1s08t+/9u9nw1VlKhGQI+RWtu6cTbvTgwk9v9MC1rLaCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dkv3zkx9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dkv3zkx9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E861C2BD10; Sun, 26 May 2024 23:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716765443; bh=lqV71dyGNzoKcV/Iv3TfEMBsKD/L3s54JM57KtyVYmo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dkv3zkx9qPFKNDRFoa351crEdyWzXNNHPoLvdZYvN+w9aarqlWKSPo/pay8YVUgG/ KjRcXMefFa4YFPGgaXXDoDTzKin5YTBi6AeCNAu6ifEyMu86Y18E6bqObOnPvFPj5t jEK6mSBl1Uja7hd6WHM/pKJ4HDtmCPS5z4ANq0kaESRfFV21H1zixHj0YQAnb9nqej wJHrQnbS0VASvaem+zQAo77fql3mV31eb8VtvNT5ltEOB+FHkrSm3l1c8dWqCFimrO TkY9gw/w3wmdKswCRNkDDXSQkomyAbormsKri2kGqHRRspPPtgkz4Ud3fZ5yPNj7ef CXRiBh/0MMPMA== Date: Mon, 27 May 2024 08:17:19 +0900 From: Masami Hiramatsu (Google) To: kernel test robot Cc: Tatsuya S , rostedt@goodmis.org, mhiramat@kernel.org, mark.rutland@arm.com, mathieu.desnoyers@efficios.com, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] ftrace: Fix stack trace entry generated by ftrace_pid_func() Message-Id: <20240527081719.a3f5b4c270d54a0453e3464f@kernel.org> In-Reply-To: <202405262232.L4XH8q6O-lkp@intel.com> References: <20240526112658.46740-1-tatsuya.s2862@gmail.com> <202405262232.L4XH8q6O-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 26 May 2024 22:51:53 +0800 kernel test robot wrote: > Hi Tatsuya, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on linus/master] > [also build test WARNING on rostedt-trace/for-next v6.9 next-20240523] > [cannot apply to rostedt-trace/for-next-urgent] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Tatsuya-S/ftrace-Fix-stack-trace-entry-generated-by-ftrace_pid_func/20240526-193149 > base: linus/master > patch link: https://lore.kernel.org/r/20240526112658.46740-1-tatsuya.s2862%40gmail.com > patch subject: [PATCH] ftrace: Fix stack trace entry generated by ftrace_pid_func() > config: x86_64-buildonly-randconfig-002-20240526 (https://download.01.org/0day-ci/archive/20240526/202405262232.L4XH8q6O-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240526/202405262232.L4XH8q6O-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202405262232.L4XH8q6O-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> kernel/trace/ftrace.c:102:6: warning: no previous prototype for function 'ftrace_pids_enabled' [-Wmissing-prototypes] > 102 | bool ftrace_pids_enabled(struct ftrace_ops *ops) > | ^ > kernel/trace/ftrace.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > 102 | bool ftrace_pids_enabled(struct ftrace_ops *ops) > | ^ > | static > 1 warning generated. This is because the prototype in linux/ftrace.h is placed in the #ifdef CONFIG_DYNAMIC_FTRACE block. The prototype needs to be moved outside of the block. Thank you, > > > vim +/ftrace_pids_enabled +102 kernel/trace/ftrace.c > > 101 > > 102 bool ftrace_pids_enabled(struct ftrace_ops *ops) > 103 { > 104 struct trace_array *tr; > 105 > 106 if (!(ops->flags & FTRACE_OPS_FL_PID) || !ops->private) > 107 return false; > 108 > 109 tr = ops->private; > 110 > 111 return tr->function_pids != NULL || tr->function_no_pids != NULL; > 112 } > 113 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki -- Masami Hiramatsu (Google)