From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Tom Zanussi <zanussi@kernel.org>
Subject: Re: [PATCH 0/3] tracing: Fix some selftest issues
Date: Mon, 27 May 2024 19:29:07 -0400 [thread overview]
Message-ID: <20240527192907.49c9220f@rorschach.local.home> (raw)
In-Reply-To: <171671825710.39694.6859036369216249956.stgit@devnote2>
On Sun, 26 May 2024 19:10:57 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> Hi,
>
> Here is a series of some fixes/improvements for the test modules and boot
> time selftest of kprobe events. I found a WARNING message with some boot
> time selftest configuration, which came from the combination of embedded
> kprobe generate API tests module and ftrace boot-time selftest. So the main
> problem is that the test module should not be built-in. But I also think
> this WARNING message is useless (because there are warning messages already)
> and the cleanup code is redundant. This series fixes those issues.
Note, when I enable trace tests as builtin instead of modules, I just
disable the bootup self tests when it detects this. This helps with
doing tests via config options than having to add user space code that
loads modules.
Could you do something similar?
-- Steve
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (Google) (3):
> tracing: Build event generation tests only as modules
> tracing/kprobe: Remove unneeded WARN_ON_ONCE() in selftests
> tracing/kprobe: Remove cleanup code unrelated to selftest
>
next prev parent reply other threads:[~2024-05-27 23:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 10:10 [PATCH 0/3] tracing: Fix some selftest issues Masami Hiramatsu (Google)
2024-05-26 10:11 ` [PATCH 1/3] tracing: Build event generation tests only as modules Masami Hiramatsu (Google)
2024-05-26 10:11 ` [PATCH 2/3] tracing/kprobe: Remove unneeded WARN_ON_ONCE() in selftests Masami Hiramatsu (Google)
2024-05-26 10:11 ` [PATCH 3/3] tracing/kprobe: Remove cleanup code unrelated to selftest Masami Hiramatsu (Google)
2024-05-27 23:29 ` Steven Rostedt [this message]
2024-05-28 16:46 ` [PATCH 0/3] tracing: Fix some selftest issues Masami Hiramatsu
2024-05-28 23:38 ` Masami Hiramatsu
2024-05-29 16:01 ` Tom Zanussi
2024-05-31 2:37 ` Masami Hiramatsu
2024-05-31 7:24 ` Steven Rostedt
2024-05-31 14:20 ` Masami Hiramatsu
2024-06-04 13:57 ` Steven Rostedt
2024-06-04 14:18 ` Masami Hiramatsu
2024-06-04 14:30 ` Steven Rostedt
2024-06-10 2:10 ` Masami Hiramatsu
2024-06-10 19:49 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2024-06-10 21:26 Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240527192907.49c9220f@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).