From: Steven Rostedt <rostedt@goodmis.org>
To: Tatsuya S <tatsuya.s2862@gmail.com>
Cc: mhiramat@kernel.org, mark.rutland@arm.com,
mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ftrace: Fix stack trace entry generated by ftrace_pid_func()
Date: Mon, 27 May 2024 19:49:14 -0400 [thread overview]
Message-ID: <20240527194914.2d25c4ec@rorschach.local.home> (raw)
In-Reply-To: <20240527100916.5737-2-tatsuya.s2862@gmail.com>
On Mon, 27 May 2024 18:44:56 +0900
Tatsuya S <tatsuya.s2862@gmail.com> wrote:
> On setting set_ftrace_pid, a extra entry generated by ftrace_pid_func()
> is shown on stack trace(CONFIG_UNWINDER_FRAME_POINTER=y).
>
> [004] ..... 68.459382: <stack trace>
> => 0xffffffffa00090af
> => ksys_read
> => __x64_sys_read
> => x64_sys_call
> => do_syscall_64
> => entry_SYSCALL_64_after_hwframe
>
> To resolve this issue, increment skip count
> in function_stack_trace_call() if pids are set.
Just a note, this isn't a "fix" but simply an improvement in output.
I'm happy to take this (after testing and more reviewing), but it will
be for the next merge window, and with a different subject line.
"ftrace: Hide one more entry in stack trace when ftrace_pid is enabled"
Or something like that.
Thanks,
-- Steve
next prev parent reply other threads:[~2024-05-27 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 9:44 [PATCH v2] ftrace: Fix stack trace entry generated by ftrace_pid_func() Tatsuya S
2024-05-27 23:49 ` Steven Rostedt [this message]
2024-05-28 2:55 ` Tatsuya S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240527194914.2d25c4ec@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=tatsuya.s2862@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).