From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0744817E912; Mon, 27 May 2024 23:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716853758; cv=none; b=jCnFA1ILNSiv5JJE7bNZwXZOZPhCU9qpANd3rYz/TH6gpNZDdMByo+V9WNmPF7QhaoebX+2VVAY06hJ+Ktw1OF67kEQnGzw7SrLVX9nE1rCH9XyFjqNnYkBLfnqZgoONG0gTqgKH7ENoedBPqU4+plSVlaFYXFkJs1QdNskcfD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716853758; c=relaxed/simple; bh=5m3EnQ61WrpxnMeU7r0cZtPifAGDeMV0+9Ex++zprw4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UTpdUJAtdOrVUYVh6lHfhzVR/HwI5GWQl538m8Y12xfoI+5srdksAkfYtreNc3iaZC7rPrAQxPLWmlZC9QxKJuDvx3NUqgTrpm66CVrRRU3B/QvG18W6M+muJntSRUPE2oLr0tHXlZkpwkj1m8IKI8VFYfT2maUHC9UAO6r6BuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93C6EC2BBFC; Mon, 27 May 2024 23:49:16 +0000 (UTC) Date: Mon, 27 May 2024 19:49:14 -0400 From: Steven Rostedt To: Tatsuya S Cc: mhiramat@kernel.org, mark.rutland@arm.com, mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v2] ftrace: Fix stack trace entry generated by ftrace_pid_func() Message-ID: <20240527194914.2d25c4ec@rorschach.local.home> In-Reply-To: <20240527100916.5737-2-tatsuya.s2862@gmail.com> References: <20240527100916.5737-2-tatsuya.s2862@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 27 May 2024 18:44:56 +0900 Tatsuya S wrote: > On setting set_ftrace_pid, a extra entry generated by ftrace_pid_func() > is shown on stack trace(CONFIG_UNWINDER_FRAME_POINTER=y). > > [004] ..... 68.459382: > => 0xffffffffa00090af > => ksys_read > => __x64_sys_read > => x64_sys_call > => do_syscall_64 > => entry_SYSCALL_64_after_hwframe > > To resolve this issue, increment skip count > in function_stack_trace_call() if pids are set. Just a note, this isn't a "fix" but simply an improvement in output. I'm happy to take this (after testing and more reviewing), but it will be for the next merge window, and with a different subject line. "ftrace: Hide one more entry in stack trace when ftrace_pid is enabled" Or something like that. Thanks, -- Steve