From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59C44195811 for ; Wed, 5 Jun 2024 13:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717593899; cv=none; b=NBRIQLv0wHLuQ8nIOh9ZWBANzrBmgjWdC+pCKWjtDAZEeBEr40Hwu7Llp6gNej0Nojp0qeRYgg5KiHu/Qxfsy7WxYJ5qmAjBYEcsI7Xd071C06lfZrZk+j2WsrjI4s076Yb6dZBpX2X/zbgAWrKXs2ZqzUo+z09egtrNp0HI89A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717593899; c=relaxed/simple; bh=IGgoHOYvpbTfxvF2N3hmgx/MFZ0LCAAfov2fRiE7iLc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lK9rcGAkhzDg7gHBCYHQ+x2APf64ZOos9jJnrVRQ0X5LW71Hdb+GqV4LkT5BiT5VwjflQVBz7zDfrgOBBE15VIjUumMtKeeCossgbB38ng/JsXn294KiWLkRPouUhUsFhZE4ddD1qEUuHQ+V6ICMPIhJjMDy+e9jk1DePj8gp88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io; spf=pass smtp.mailfrom=layalina.io; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b=w+Cb8xr0; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=layalina.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="w+Cb8xr0" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-35dc0472b7eso5975387f8f.2 for ; Wed, 05 Jun 2024 06:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1717593897; x=1718198697; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xq9gIboeIP0lLm6D7yyfMwZHyoZ/EmvE2lx3bVnUJH8=; b=w+Cb8xr0DLUkEiF25I2+ao+PrrD+CxzU7bXJkwia1qIQFJe5qePWIGI6knsgLGx925 1pg0KmdvOqp2JaKkyFjqZycakRMvp9Ui3ipK60zOysjUEP0EQWImgJ5LozNmHHnCEyLJ 7juMRmSymxXA8FpewX7CwIfEO/9XiHOPerghwCcHNyAIyH/F2oxlHOo+YgL5qez8bfB2 y9OXJwvmgeYtc2hT6SgLrd+cyRRbIy1gnIflaYFRPj4NWeuKDHekS4v761pmGrSq0Grf NIGb6c/d2bfjJdsg/aN2WU3XSbXXJPpYqj24r7pkJB17VHsJhF7n5Rzf92oSGpFePZ6U bisg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717593897; x=1718198697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xq9gIboeIP0lLm6D7yyfMwZHyoZ/EmvE2lx3bVnUJH8=; b=gWC8vDU6lUGSd/Gj8qT0EzgTAqNitwLLetYK/SDVRGXWdh7gGwAF01EWvYRh+6buWs 5w1ieCIY6FJnOzhV5d69PXHSxvV7XNdrGrZNFKHfq6XQuljqEE4l4dBHya3NHNle9hrg bZAtXXFz5YXpx6J7Ok5CeLVCllb7Zm2/B0WenD+/HDlauAvA6nV378vLhz654iC2OcEe 7V6kyoKR9xm8WMXAdggmhW3t05OI6vwwq9dM93io/9RoRZxVkQKtMGvixZqiSTjCs6H5 KOwaOvYjGNUvfhgSXQEqfjLTufF3j8pE6YYeqwDHDO+TljZ4nH+xYgafdJDCuSSncH4r 62Eg== X-Forwarded-Encrypted: i=1; AJvYcCVnHJwWW/lmSgg8hDy/F6ABXyc8I4I56qiKzcoFfRR5Y21FpmEjQMdTXu2zukCo43TdmuQjiCzvgdWP8lZLpoQICmdu1o8PvGO/aseZ7f7KQapH X-Gm-Message-State: AOJu0YxxZmlrfevVUU9wQZHcLMJrwRbhm6yFObR/deqm2PP+TAOEU7tR dAgZADSqAjEYsMeew9WZfW1GZQQUHF6Zz8jzHFLktvtK74vCT6YatBDnAaRLob8= X-Google-Smtp-Source: AGHT+IEDSLWBHNvCjuH/hvXgGFQjAPtCtaPrhm+JcG8FGeW9Ms1o+F8Qs/onHstEDi9CUXB1JupgJg== X-Received: by 2002:a05:6000:1f8c:b0:35e:5b61:23b8 with SMTP id ffacd0b85a97d-35e85feecf2mr2435818f8f.34.1717593896475; Wed, 05 Jun 2024 06:24:56 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04c0f7esm14621490f8f.22.2024.06.05.06.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 06:24:56 -0700 (PDT) Date: Wed, 5 Jun 2024 14:24:54 +0100 From: Qais Yousef To: Sebastian Andrzej Siewior Cc: Daniel Bristot de Oliveira , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() Message-ID: <20240605132454.cjo4sjtybaeyeuze@airbuntu> References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240605093246.4h0kCR67@linutronix.de> On 06/05/24 11:32, Sebastian Andrzej Siewior wrote: > On 2024-06-04 17:57:46 [+0200], Daniel Bristot de Oliveira wrote: > > On 6/4/24 16:42, Qais Yousef wrote: > > > - (wakeup_rt && !dl_task(p) && !rt_task(p)) || > > > + (wakeup_rt && !realtime_task(p)) || > > > > I do not like bikeshedding, and no hard feelings... No hard feelings :-) > > > > But rt is a shortened version of realtime, and so it is making *it less* > > clear that we also have DL here. > > Can SCHED_DL be considered a real-time scheduling class as in opposite > to SCHED_BATCH for instance? Due to its requirements it fits for a real > time scheduling class, right? > And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. Yeah I think the usage of realtime to cover both makes sense. I followed your precedence with task_is_realtime(). Anyway. If people really find this confusing, what would make sense is to split them and ask users to call rt_task() and dl_task() explicitly without this wrapper. I personally like it better with the wrapper. But happy to follow the crowd.