From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C7A14D6E9 for ; Mon, 10 Jun 2024 19:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718047306; cv=none; b=lfunAAzr+GnM+Kv3Ug/QczlmDDTGkGgM2GdVFKDmYKnEELJHZVCccaf9lffmvtPs1VR3UZEEkwlXTengG3BlbYPljANjCuY2wVgNGyREMsYC3qk6S/r8wjOEbQYU+7lD2dDii+vMnIIvnXf+0tK7LkiWVdnjC+zDhIZdP057yCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718047306; c=relaxed/simple; bh=sRPSbauIiYaJtGBZEqHyUjPGKFPTk5/HdK22FraU4hI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SyvPxH6mEjCWc3fkDjXrAMrOEiFjvCc9DDtwgvNsA0TTvlInpbUiYKiuAANxxLGvM2V9h4mO/vd/fkGawqcBCCLwvWCqJaOy47ivLvaRazyRYZmfB6RmrV7VBM/KsTibpsU0KVzI+eEsX0w+mXhKpjvS+DtWO8vVscdtnn8Fjws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io; spf=pass smtp.mailfrom=layalina.io; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b=yu4AdpGP; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=layalina.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="yu4AdpGP" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-421b9068274so12509695e9.1 for ; Mon, 10 Jun 2024 12:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1718047303; x=1718652103; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; b=yu4AdpGPnGacd6cwDL/DtvxZdGK7JNjq6XhqddfsUOrB9ei6PFiw9i+1x+XCuAeY0p 23+RU+W+zLREQV9HwK8KBYtOrpYNJy5UavMnUMZ/lIFargodujaMzg5YBo4gNcRouLS/ dCAlI/AXRrRr0hte6iC79QKf3wcx3kr2qhDRxVpen/FvdMBkVLz9OHmV2PskG7TBXJSd G2hrJubxJ6oaXs0SFJHQh2ixFBQoB45sPXW/GLH70gWUT6UrH++tnKjk8dJd/vVVHQqY NbIZTKoJ8TGVZeQq4JCT6ZFSPDc1yGd6MVliszLBXrJ56JwkDHsOrv3Kvkr4jv+eSVF0 pgkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718047303; x=1718652103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; b=a/0f+um+UIuCi1J6kuEOXjQyXMCdRD48yLAYIbeN0zY3+bbCEOjOn5bayqtoxAwSDG LmfGjofHy92IFzhpcC7wp44q2eE5oIWrpF+Q/gfLBavBNyO7wFl80GHWUfOtsxjH5EvK o1KpYQS8sU/SST4UPDxdo+80bg+CUwfrchnfeVFZR/8MSd28rUTWt+ztYd/6grZdBfey qOmJ7wzcoxIwUMdT9BVkMiuzkuWQjhi0HMbpCjVkgNtmHv2w3U7zeooZZPrhJNhV9lKM xAtzfxHgmUCRN0xwAte3PXKEz9pdtctp8x5ZnHUR91QQyTcCjm1q1tCDmJTpj1+DXkEg Edew== X-Forwarded-Encrypted: i=1; AJvYcCUetDdVefuNM9IIA78Z3fEguoGC6EY6B/IYwtJ8E/W1qsdrho7D/5/prhHvKTGOl4zeR44rVGgmNv8QR/9rKA077GGLBB5gP1EGDWwZYB0i2lvj X-Gm-Message-State: AOJu0Yxp/KGskuiTDWYfP2uUxZ5PdyFznHAcdPWKTvOjWheUsl1964Iv 2ji8Y7omJkw8mnao7bTiPMBHXpBxWvsQ8TN2qZYdLf2vkEcYrtHD3WliW+rD6og= X-Google-Smtp-Source: AGHT+IG5R+6QdrL5vtPI3P3UQJ+Eps+bOHM+4T1uVpoya5SI1oL4hgnotnXL1Fs02cAYdrCTAMaMxg== X-Received: by 2002:a05:600c:138e:b0:421:2df2:2850 with SMTP id 5b1f17b1804b1-42164a21d60mr105810015e9.31.1718047303182; Mon, 10 Jun 2024 12:21:43 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4218193b0c0sm65469985e9.31.2024.06.10.12.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 12:21:42 -0700 (PDT) Date: Mon, 10 Jun 2024 20:21:41 +0100 From: Qais Yousef To: Daniel Bristot de Oliveira Cc: Sebastian Andrzej Siewior , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() Message-ID: <20240610192141.dibvhzrvx7hacvd7@airbuntu> References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> <20240605132454.cjo4sjtybaeyeuze@airbuntu> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On 06/05/24 16:07, Daniel Bristot de Oliveira wrote: > On 6/5/24 15:24, Qais Yousef wrote: > >>> But rt is a shortened version of realtime, and so it is making *it less* > >>> clear that we also have DL here. > >> Can SCHED_DL be considered a real-time scheduling class as in opposite > >> to SCHED_BATCH for instance? Due to its requirements it fits for a real > >> time scheduling class, right? > >> And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. > > Yeah I think the usage of realtime to cover both makes sense. I followed your > > precedence with task_is_realtime(). > > > > Anyway. If people really find this confusing, what would make sense is to split > > them and ask users to call rt_task() and dl_task() explicitly without this > > wrapper. I personally like it better with the wrapper. But happy to follow the > > crowd. > > For me, doing dl_ things it is better to keep them separate, so I can > easily search for dl_ specific checks. > > rt_or_dl_task(p); I posted a new version with this suggestion as the top patch so that it can be shredded more :-) Thanks for having a look. Cheers -- Qais Yousef