From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Tom Zanussi <zanussi@kernel.org>
Subject: Re: [PATCH v3 2/3] tracing/kprobe: Integrate test warnings into WARN_ONCE
Date: Tue, 11 Jun 2024 10:24:14 -0400 [thread overview]
Message-ID: <20240611102414.203b95bd@gandalf.local.home> (raw)
In-Reply-To: <171811264685.85078.8068819097047430463.stgit@devnote2>
On Tue, 11 Jun 2024 22:30:46 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Cleanup the redundant WARN_ON_ONCE(cond) + pr_warn(msg) into
> WARN_ONCE(cond, msg). Also add some WARN_ONCE() for hitcount check.
> These WARN_ONCE() errors makes it easy to handle errors from ktest.
>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> Changes in v3:
> - integrate WARN_ON_ONCE() and pr_warn() instead of remove
> WARN_ONCE().
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2024-06-11 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 13:30 [PATCH v3 0/3] tracing: Fix some selftest issues Masami Hiramatsu (Google)
2024-06-11 13:30 ` [PATCH v3 1/3] tracing: Build event generation tests only as modules Masami Hiramatsu (Google)
2024-06-11 13:30 ` [PATCH v3 2/3] tracing/kprobe: Integrate test warnings into WARN_ONCE Masami Hiramatsu (Google)
2024-06-11 14:24 ` Steven Rostedt [this message]
2024-06-11 13:30 ` [PATCH v3 3/3] tracing/kprobe: Remove cleanup code unrelated to selftest Masami Hiramatsu (Google)
2024-06-11 14:25 ` Steven Rostedt
2024-06-11 23:11 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611102414.203b95bd@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).