linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii@kernel.org>
To: linux-trace-kernel@vger.kernel.org, rostedt@goodmis.org,
	mhiramat@kernel.org, oleg@redhat.com
Cc: peterz@infradead.org, mingo@redhat.com, bpf@vger.kernel.org,
	jolsa@kernel.org, paulmck@kernel.org, clm@meta.com,
	Andrii Nakryiko <andrii@kernel.org>
Subject: [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode()
Date: Mon,  1 Jul 2024 15:39:25 -0700	[thread overview]
Message-ID: <20240701223935.3783951-3-andrii@kernel.org> (raw)
In-Reply-To: <20240701223935.3783951-1-andrii@kernel.org>

It seems like uprobe_write_opcode() doesn't require writer locked
mmap_sem, any lock (reader or writer) should be sufficient. This was
established in a discussion in [0] and looking through existing code
seems to confirm that there is no need for write-locked mmap_sem.

Fix the comment to state this clearly.

  [0] https://lore.kernel.org/linux-trace-kernel/20240625190748.GC14254@redhat.com/

Fixes: 29dedee0e693 ("uprobes: Add mem_cgroup_charge_anon() into uprobe_write_opcode()")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
 kernel/events/uprobes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 081821fd529a..f87049c08ee9 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -453,7 +453,7 @@ static int update_ref_ctr(struct uprobe *uprobe, struct mm_struct *mm,
  * @vaddr: the virtual address to store the opcode.
  * @opcode: opcode to be written at @vaddr.
  *
- * Called with mm->mmap_lock held for write.
+ * Called with mm->mmap_lock held for read or write.
  * Return 0 (success) or a negative errno.
  */
 int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
-- 
2.43.0


  parent reply	other threads:[~2024-07-01 22:39 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 22:39 [PATCH v2 00/12] uprobes: add batched register/unregister APIs and per-CPU RW semaphore Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 01/12] uprobes: update outdated comment Andrii Nakryiko
2024-07-03 11:38   ` Oleg Nesterov
2024-07-03 18:24     ` Andrii Nakryiko
2024-07-03 21:51     ` Andrii Nakryiko
2024-07-10 13:31     ` Oleg Nesterov
2024-07-10 15:14       ` Andrii Nakryiko
2024-07-01 22:39 ` Andrii Nakryiko [this message]
2024-07-03 11:41   ` [PATCH v2 02/12] uprobes: correct mmap_sem locking assumptions in uprobe_write_opcode() Oleg Nesterov
2024-07-03 13:15   ` Masami Hiramatsu
2024-07-03 18:25     ` Andrii Nakryiko
2024-07-03 21:47       ` Masami Hiramatsu
2024-07-01 22:39 ` [PATCH v2 03/12] uprobes: simplify error handling for alloc_uprobe() Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management Andrii Nakryiko
2024-07-02 10:22   ` Peter Zijlstra
2024-07-02 17:54     ` Andrii Nakryiko
2024-07-03 13:36   ` Peter Zijlstra
2024-07-03 20:47     ` Andrii Nakryiko
2024-07-04  8:03       ` Peter Zijlstra
2024-07-04  8:45         ` Peter Zijlstra
2024-07-04 14:40           ` Masami Hiramatsu
2024-07-04  8:31       ` Peter Zijlstra
2024-07-05 15:37   ` Oleg Nesterov
2024-07-06 17:00     ` Jiri Olsa
2024-07-06 17:05       ` Jiri Olsa
2024-07-07 14:46     ` Oleg Nesterov
2024-07-08 17:47       ` Andrii Nakryiko
2024-07-09 18:47         ` Oleg Nesterov
2024-07-09 20:59           ` Andrii Nakryiko
2024-07-09 21:31             ` Oleg Nesterov
2024-07-09 21:45               ` Andrii Nakryiko
2024-07-08 17:47     ` Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 05/12] uprobes: move offset and ref_ctr_offset into uprobe_consumer Andrii Nakryiko
2024-07-03  8:13   ` Peter Zijlstra
2024-07-03 10:13     ` Masami Hiramatsu
2024-07-03 18:23       ` Andrii Nakryiko
2024-07-07 12:48   ` Oleg Nesterov
2024-07-08 17:56     ` Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 06/12] uprobes: add batch uprobe register/unregister APIs Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 07/12] uprobes: inline alloc_uprobe() logic into __uprobe_register() Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 08/12] uprobes: split uprobe allocation and uprobes_tree insertion steps Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 09/12] uprobes: batch uprobes_treelock during registration Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 10/12] uprobes: improve lock batching for uprobe_unregister_batch Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 11/12] uprobes,bpf: switch to batch uprobe APIs for BPF multi-uprobes Andrii Nakryiko
2024-07-01 22:39 ` [PATCH v2 12/12] uprobes: switch uprobes_treelock to per-CPU RW semaphore Andrii Nakryiko
2024-07-02 10:23 ` [PATCH v2 00/12] uprobes: add batched register/unregister APIs and " Peter Zijlstra
2024-07-02 11:54   ` Peter Zijlstra
2024-07-02 12:01     ` Peter Zijlstra
2024-07-02 17:54     ` Andrii Nakryiko
2024-07-02 19:18       ` Peter Zijlstra
2024-07-02 23:56         ` Paul E. McKenney
2024-07-03  4:54           ` Andrii Nakryiko
2024-07-03  7:50           ` Peter Zijlstra
2024-07-03 14:08             ` Paul E. McKenney
2024-07-04  8:39               ` Peter Zijlstra
2024-07-04 15:13                 ` Paul E. McKenney
2024-07-03 21:57             ` Steven Rostedt
2024-07-03 22:07               ` Paul E. McKenney
2024-07-03  4:47         ` Andrii Nakryiko
2024-07-03  8:07           ` Peter Zijlstra
2024-07-03 20:55             ` Andrii Nakryiko
2024-07-03 21:33 ` Andrii Nakryiko
2024-07-04  9:15   ` Peter Zijlstra
2024-07-04 13:56     ` Steven Rostedt
2024-07-04 15:44     ` Paul E. McKenney
2024-07-08 17:47       ` Andrii Nakryiko
2024-07-08 17:48     ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240701223935.3783951-3-andrii@kernel.org \
    --to=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=clm@meta.com \
    --cc=jolsa@kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).