From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux trace kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Dmitry V. Levin" <ldv@strace.io>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] tracing: Have memmapped ring buffer use ioctl of "R" range 0x20-2F
Date: Wed, 3 Jul 2024 08:59:04 +0900 [thread overview]
Message-ID: <20240703085904.aad69ff3e56eb413de81a3c5@kernel.org> (raw)
In-Reply-To: <20240702153354.367861db@rorschach.local.home>
On Tue, 2 Jul 2024 15:33:54 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> To prevent conflicts with other ioctl numbers to allow strace to have an
> idea of what is happening, add the rang of ioctls for the trace buffer
> mapping from _IO("T", 0x1) to the range of "R" 0x20 - 0x2F.
>
> Link: https://lore.kernel.org/linux-trace-kernel/20240630105322.GA17573@altlinux.org/
>
> Reported-by: "Dmitry V. Levin" <ldv@strace.io>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks,
> ---
> Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
> include/uapi/linux/trace_mmap.h | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index a141e8e65c5d..9a97030c6c8d 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -186,6 +186,7 @@ Code Seq# Include File Comments
> 'Q' all linux/soundcard.h
> 'R' 00-1F linux/random.h conflict!
> 'R' 01 linux/rfkill.h conflict!
> +'R' 20-2F linux/trace_mmap.h
> 'R' C0-DF net/bluetooth/rfcomm.h
> 'R' E0 uapi/linux/fsl_mc.h
> 'S' all linux/cdrom.h conflict!
> diff --git a/include/uapi/linux/trace_mmap.h b/include/uapi/linux/trace_mmap.h
> index bd1066754220..c102ef35d11e 100644
> --- a/include/uapi/linux/trace_mmap.h
> +++ b/include/uapi/linux/trace_mmap.h
> @@ -43,6 +43,6 @@ struct trace_buffer_meta {
> __u64 Reserved2;
> };
>
> -#define TRACE_MMAP_IOCTL_GET_READER _IO('T', 0x1)
> +#define TRACE_MMAP_IOCTL_GET_READER _IO('R', 0x20)
>
> #endif /* _TRACE_MMAP_H_ */
> --
> 2.43.0
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2024-07-02 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 19:33 [PATCH] tracing: Have memmapped ring buffer use ioctl of "R" range 0x20-2F Steven Rostedt
2024-07-02 19:38 ` Mathieu Desnoyers
2024-07-02 19:41 ` Steven Rostedt
2024-07-02 23:59 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703085904.aad69ff3e56eb413de81a3c5@kernel.org \
--to=mhiramat@kernel.org \
--cc=corbet@lwn.net \
--cc=ldv@strace.io \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).