From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 839DF198A06; Wed, 10 Jul 2024 16:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720629387; cv=none; b=u/dlIfjXtGytyJgLOOCFnjXURJ+72mBWir/zeIc6u6VBGnLp9p4KzMbfzpTgrZ/c5r1sbSAL7fWx7FqMpkli0HFzOITUlrMc8Gh6qeFxvtYGhYO24GK1nC+Cs/5YFx+47ZkVGojTEkLrVH3ujfPoG12AnOWkw2IM9W41YaPgjWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720629387; c=relaxed/simple; bh=VOEQami4KT93qBtaeJsQ3QrGdn1x7XmqJH9KjXDTUok=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YOQgTXVT5Mk+UUvrf7bx0Am8Ni026QrPub4DJP/2ixizPphjjbcILbWJK+zQkLUVToOJ3PbeM0uCXjdzbNSGfuIUXDQmK/LjGPhuI3Wm4Ewb7iojAAXERTJcJ1689SQg4EprXjIBvdyWrubmNaLla5v+raW2SRsYtKnDXX0mrmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aOB39CZJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aOB39CZJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D988C4AF0E; Wed, 10 Jul 2024 16:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720629387; bh=VOEQami4KT93qBtaeJsQ3QrGdn1x7XmqJH9KjXDTUok=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aOB39CZJyMSyw1K+rruCMig4enLLpVwC4wmcFjrJNki6A1jlaMJwosJ9qi8gRob9s z7kFdpwuqr9jEMtf/y6F9JBirzQmzNumlVlD4b5l1/DcvZl1p0vOnft2M9nqMidkg2 fMeKFVzWzpdKvcOJw8T8tVAueyIBUoE5fy6eFWwP05DhpQeDO1LP4UgyB2r6dI3IcB VwAb4piQ8k8z2t0MaNbM+KdSE042QTqyYizf8pBU/ymZjtyw0F38O1P7ZzGOvlO5KG spFlwBsXz0iOlmIq8Tsu0Zw/Wqy210Von3cqCm6mraFQxJZhjqMZtEzBl7xdBYwb2m CVueEk61o919A== Date: Wed, 10 Jul 2024 09:36:24 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , "Christian =?UTF-8?B?S8O2bmln?=" , Bagas Sanjaya , Christoph Hellwig , Nikolay Aleksandrov , Taehee Yoo , Pavel Begunkov , David Wei , Jason Gunthorpe , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , Willem de Bruijn , Kaiyuan Zhang Subject: Re: [PATCH net-next v16 04/13] netdev: netdevice devmem allocator Message-ID: <20240710093624.26d22f02@kernel.org> In-Reply-To: <20240710001749.1388631-5-almasrymina@google.com> References: <20240710001749.1388631-1-almasrymina@google.com> <20240710001749.1388631-5-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Jul 2024 00:17:37 +0000 Mina Almasry wrote: > + net_devmem_dmabuf_binding_get(binding); Why does every iov need to hold a ref? pp holds a ref and does its own accounting, so it won't disappear unless all the pages are returned.