From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Menglong Dong <menglong8.dong@gmail.com>,
mhiramat@kernel.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org,
Menglong Dong <dongml2@chinatelecom.cn>
Subject: Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override
Date: Wed, 10 Jul 2024 23:18:05 +0900 [thread overview]
Message-ID: <20240710231805.868703dc681815bb2257b0ac@kernel.org> (raw)
In-Reply-To: <Zo6I47BQlLnNN3R-@krava>
On Wed, 10 Jul 2024 15:13:07 +0200
Jiri Olsa <olsajiri@gmail.com> wrote:
> On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
>
> should be in Fixes: tag probably ?
Yes, I'll add a Fixed tag.
>
> > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > anymore, and we can remove it now.
> >
> > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
>
> lgtm, cc-ing Masami
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks!
>
> jirka
>
> > ---
> > include/linux/trace_events.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > index 9df3e2973626..9435185c10ef 100644
> > --- a/include/linux/trace_events.h
> > +++ b/include/linux/trace_events.h
> > @@ -880,7 +880,6 @@ do { \
> > struct perf_event;
> >
> > DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> >
> > extern int perf_trace_init(struct perf_event *event);
> > extern void perf_trace_destroy(struct perf_event *event);
> > --
> > 2.39.2
> >
> >
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-07-10 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 8:59 [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override Menglong Dong
2024-07-10 13:13 ` Jiri Olsa
2024-07-10 14:18 ` Masami Hiramatsu [this message]
2024-07-18 1:32 ` Menglong Dong
2024-07-18 14:51 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710231805.868703dc681815bb2257b0ac@kernel.org \
--to=mhiramat@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dongml2@chinatelecom.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=menglong8.dong@gmail.com \
--cc=olsajiri@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).