From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, andrii@kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
rostedt@goodmis.org, mhiramat@kernel.org, jolsa@kernel.org,
clm@meta.com, paulmck@kernel.org
Subject: Re: [PATCH v2 10/11] perf/uprobe: Convert single-step and uretprobe to SRCU
Date: Fri, 12 Jul 2024 12:26:27 +0200 [thread overview]
Message-ID: <20240712102627.GA31100@redhat.com> (raw)
In-Reply-To: <20240711184251.GD27299@noisy.programming.kicks-ass.net>
On 07/11, Peter Zijlstra wrote:
>
> uprobe_free_stage1
> call_srcu(&uretprobe_srcu, &uprobe->rcu, uprobe_free_stage2);
>
> put_uprobe()
> if (refcount_dec_and_test)
> call_srcu(&uprobes_srcu, &uprobe->rcu, uprobe_free_stage1);
>
>
> So my thinking was since we take uretprobe_srcu *inside* uprobe_srcu,
Ah, indeed! Somehow misread the change in put_uprobe() as if it
uses call_rcu(uretprobe_srcu).
Thanks,
Oleg.
next prev parent reply other threads:[~2024-07-12 10:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 11:02 [PATCH v2 00/11] perf/uprobe: Optimize uprobes Peter Zijlstra
2024-07-11 11:02 ` [PATCH v2 01/11] perf/uprobe: Re-indent labels Peter Zijlstra
2024-07-11 11:58 ` Jiri Olsa
2024-07-11 12:07 ` Peter Zijlstra
2024-07-11 11:02 ` [PATCH v2 02/11] perf/uprobe: Remove spurious whitespace Peter Zijlstra
2024-07-11 11:02 ` [PATCH v2 03/11] rbtree: Provide rb_find_rcu() / rb_find_add_rcu() Peter Zijlstra
2024-07-12 20:23 ` Andrii Nakryiko
2024-07-15 11:21 ` Peter Zijlstra
2024-07-15 17:13 ` Andrii Nakryiko
2024-07-11 11:02 ` [PATCH v2 04/11] perf/uprobe: RCU-ify find_uprobe() Peter Zijlstra
2024-07-11 13:59 ` Masami Hiramatsu
2024-07-11 11:02 ` [PATCH v2 05/11] perf/uprobe: Simplify UPROBE_HANDLER_REMOVE logic Peter Zijlstra
2024-07-11 11:02 ` [PATCH v2 06/11] perf/uprobe: SRCU-ify uprobe->consumer list Peter Zijlstra
2024-07-12 21:06 ` Andrii Nakryiko
2024-07-15 11:25 ` Peter Zijlstra
2024-07-15 17:30 ` Andrii Nakryiko
2024-07-11 11:02 ` [PATCH v2 07/11] perf/uprobe: Split uprobe_unregister() Peter Zijlstra
2024-07-12 21:10 ` Andrii Nakryiko
2024-07-11 11:02 ` [PATCH v2 08/11] perf/uprobe: Convert (some) uprobe->refcount to SRCU Peter Zijlstra
2024-07-11 14:03 ` Jiri Olsa
2024-07-12 21:21 ` Andrii Nakryiko
2024-07-11 11:02 ` [PATCH v2 09/11] srcu: Add __srcu_clone_read_lock() Peter Zijlstra
2024-07-11 11:02 ` [PATCH v2 10/11] perf/uprobe: Convert single-step and uretprobe to SRCU Peter Zijlstra
2024-07-11 16:06 ` Oleg Nesterov
2024-07-11 18:42 ` Peter Zijlstra
2024-07-12 10:26 ` Oleg Nesterov [this message]
2024-07-12 21:28 ` Andrii Nakryiko
2024-07-15 11:59 ` Peter Zijlstra
2024-07-11 11:02 ` [PATCH v2 11/11] perf/uprobe: Add uretprobe timer Peter Zijlstra
2024-07-11 13:19 ` Oleg Nesterov
2024-07-11 15:00 ` Peter Zijlstra
2024-07-11 15:55 ` Peter Zijlstra
2024-07-11 16:06 ` Peter Zijlstra
2024-07-12 21:43 ` Andrii Nakryiko
2024-07-15 11:41 ` Peter Zijlstra
2024-07-15 17:34 ` Andrii Nakryiko
2024-07-12 4:57 ` [PATCH v2 00/11] perf/uprobe: Optimize uprobes Andrii Nakryiko
2024-07-12 9:13 ` Peter Zijlstra
2024-07-12 13:10 ` Peter Zijlstra
2024-07-12 15:29 ` Andrii Nakryiko
2024-07-15 14:45 ` Peter Zijlstra
2024-07-15 17:10 ` Andrii Nakryiko
2024-07-15 18:10 ` Andrii Nakryiko
2024-07-19 18:42 ` Andrii Nakryiko
2024-07-27 0:18 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712102627.GA31100@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=clm@meta.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).