* [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and next_comm in right order
@ 2024-07-03 3:33 Tio Zhang
2024-07-15 19:04 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Tio Zhang @ 2024-07-03 3:33 UTC (permalink / raw)
To: rostedt, mhiramat
Cc: linux-kernel, linux-trace-kernel, vineethr, akpm,
mathieu.desnoyers, tiozhang, mingo, mgorman, peterz, qyousef,
vincent.guittot, elver, zyhtheonly, zyhtheonly
Switch the order of prev_comm and next_comm in sched_switch's code to
align with its printing order.
Signed-off-by: Tio Zhang <tiozhang@didiglobal.com>
Reviewed-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
---
include/trace/events/sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index dbb01b4b7451..a4bd4330db4c 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -239,11 +239,11 @@ TRACE_EVENT(sched_switch,
),
TP_fast_assign(
- memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
+ memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
__entry->prev_pid = prev->pid;
__entry->prev_prio = prev->prio;
__entry->prev_state = __trace_sched_switch_state(preempt, prev_state, prev);
- memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
+ memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
__entry->next_pid = next->pid;
__entry->next_prio = next->prio;
/* XXX SCHED_DEADLINE */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and next_comm in right order
2024-07-03 3:33 [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and next_comm in right order Tio Zhang
@ 2024-07-15 19:04 ` Steven Rostedt
2024-07-16 9:18 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2024-07-15 19:04 UTC (permalink / raw)
To: Tio Zhang
Cc: mhiramat, linux-kernel, linux-trace-kernel, vineethr, akpm,
mathieu.desnoyers, mingo, mgorman, peterz, qyousef,
vincent.guittot, elver, zyhtheonly, zyhtheonly, Peter Zijlstra,
Ingo Molnar, Juri Lelli, Vincent Guittot, Dietmar Eggemann,
Ben Segall, Mel Gorman, Valentin Schneider
[ Adding sched maintainers, as this is a scheduling trace event ]
On Wed, 3 Jul 2024 11:33:53 +0800
Tio Zhang <tiozhang@didiglobal.com> wrote:
> Switch the order of prev_comm and next_comm in sched_switch's code to
> align with its printing order.
I'm going to pick this up in my tree, as it is pretty much a nop. It's
just changing the ordering of the assignments of the comm names so that
the copy of prev_comm is with the updates to the prev_fields, and the
next_comm is with the updates to the next fields.
-- Steve
>
> Signed-off-by: Tio Zhang <tiozhang@didiglobal.com>
> Reviewed-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
> ---
> include/trace/events/sched.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> index dbb01b4b7451..a4bd4330db4c 100644
> --- a/include/trace/events/sched.h
> +++ b/include/trace/events/sched.h
> @@ -239,11 +239,11 @@ TRACE_EVENT(sched_switch,
> ),
>
> TP_fast_assign(
> - memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
> + memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
> __entry->prev_pid = prev->pid;
> __entry->prev_prio = prev->prio;
> __entry->prev_state = __trace_sched_switch_state(preempt, prev_state, prev);
> - memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
> + memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
> __entry->next_pid = next->pid;
> __entry->next_prio = next->prio;
> /* XXX SCHED_DEADLINE */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and next_comm in right order
2024-07-15 19:04 ` Steven Rostedt
@ 2024-07-16 9:18 ` Peter Zijlstra
0 siblings, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2024-07-16 9:18 UTC (permalink / raw)
To: Steven Rostedt
Cc: Tio Zhang, mhiramat, linux-kernel, linux-trace-kernel, vineethr,
akpm, mathieu.desnoyers, mingo, mgorman, qyousef, vincent.guittot,
elver, zyhtheonly, zyhtheonly, Juri Lelli, Dietmar Eggemann,
Ben Segall, Mel Gorman, Valentin Schneider
On Mon, Jul 15, 2024 at 03:04:12PM -0400, Steven Rostedt wrote:
>
> [ Adding sched maintainers, as this is a scheduling trace event ]
>
> On Wed, 3 Jul 2024 11:33:53 +0800
> Tio Zhang <tiozhang@didiglobal.com> wrote:
>
> > Switch the order of prev_comm and next_comm in sched_switch's code to
> > align with its printing order.
>
> I'm going to pick this up in my tree, as it is pretty much a nop. It's
> just changing the ordering of the assignments of the comm names so that
> the copy of prev_comm is with the updates to the prev_fields, and the
> next_comm is with the updates to the next fields.
Right, have at. very close to a whitespace patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-16 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-03 3:33 [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and next_comm in right order Tio Zhang
2024-07-15 19:04 ` Steven Rostedt
2024-07-16 9:18 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).