* Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro [not found] <20240531-md-lib-test_objpool-v1-1-516efee92a05@quicinc.com> @ 2024-06-03 3:25 ` wuqiang.matt 2024-06-03 6:45 ` Masami Hiramatsu 0 siblings, 1 reply; 7+ messages in thread From: wuqiang.matt @ 2024-06-03 3:25 UTC (permalink / raw) To: Jeff Johnson, Andrew Morton, Masami Hiramatsu Cc: linux-kernel, kernel-janitors, linux-trace-kernel On 2024/6/1 08:31, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > lib/test_objpool.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/test_objpool.c b/lib/test_objpool.c > index bfdb81599832..5a3f6961a70f 100644 > --- a/lib/test_objpool.c > +++ b/lib/test_objpool.c > @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void) > module_init(ot_mod_init); > module_exit(ot_mod_exit); > > -MODULE_LICENSE("GPL"); > \ No newline at end of file > +MODULE_DESCRIPTION("Test module for lockless object pool"); > +MODULE_LICENSE("GPL"); > > --- > base-commit: b050496579632f86ee1ef7e7501906db579f3457 > change-id: 20240531-md-lib-test_objpool-338d937f8666 > Looks good to me. Thanks for the update. I added Masami Hiramatsu and linux-trace in the loop. Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com> Regards, Matt Wu ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro 2024-06-03 3:25 ` [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro wuqiang.matt @ 2024-06-03 6:45 ` Masami Hiramatsu 2024-07-11 18:14 ` Jeff Johnson 0 siblings, 1 reply; 7+ messages in thread From: Masami Hiramatsu @ 2024-06-03 6:45 UTC (permalink / raw) To: wuqiang.matt Cc: Jeff Johnson, Andrew Morton, linux-kernel, kernel-janitors, linux-trace-kernel On Mon, 3 Jun 2024 11:25:59 +0800 "wuqiang.matt" <wuqiang.matt@bytedance.com> wrote: > On 2024/6/1 08:31, Jeff Johnson wrote: > > make allmodconfig && make W=1 C=1 reports: > > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o > > > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > --- > > lib/test_objpool.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/test_objpool.c b/lib/test_objpool.c > > index bfdb81599832..5a3f6961a70f 100644 > > --- a/lib/test_objpool.c > > +++ b/lib/test_objpool.c > > @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void) > > module_init(ot_mod_init); > > module_exit(ot_mod_exit); > > > > -MODULE_LICENSE("GPL"); > > \ No newline at end of file > > +MODULE_DESCRIPTION("Test module for lockless object pool"); > > +MODULE_LICENSE("GPL"); > > > > --- > > base-commit: b050496579632f86ee1ef7e7501906db579f3457 > > change-id: 20240531-md-lib-test_objpool-338d937f8666 > > > > Looks good to me. Thanks for the update. > > I added Masami Hiramatsu and linux-trace in the loop. > > Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com> Thanks, let me pick this to probes/for-next branch. Thank you, > > Regards, > Matt Wu > -- Masami Hiramatsu (Google) <mhiramat@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro 2024-06-03 6:45 ` Masami Hiramatsu @ 2024-07-11 18:14 ` Jeff Johnson 2024-07-15 8:30 ` Masami Hiramatsu 2024-07-15 9:12 ` Masami Hiramatsu 0 siblings, 2 replies; 7+ messages in thread From: Jeff Johnson @ 2024-07-11 18:14 UTC (permalink / raw) To: Masami Hiramatsu (Google), wuqiang.matt Cc: Andrew Morton, linux-kernel, kernel-janitors, linux-trace-kernel On 6/2/24 23:45, Masami Hiramatsu (Google) wrote: > On Mon, 3 Jun 2024 11:25:59 +0800 > "wuqiang.matt" <wuqiang.matt@bytedance.com> wrote: > >> On 2024/6/1 08:31, Jeff Johnson wrote: >>> make allmodconfig && make W=1 C=1 reports: >>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o >>> >>> Add the missing invocation of the MODULE_DESCRIPTION() macro. >>> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >>> --- >>> lib/test_objpool.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/test_objpool.c b/lib/test_objpool.c >>> index bfdb81599832..5a3f6961a70f 100644 >>> --- a/lib/test_objpool.c >>> +++ b/lib/test_objpool.c >>> @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void) >>> module_init(ot_mod_init); >>> module_exit(ot_mod_exit); >>> >>> -MODULE_LICENSE("GPL"); >>> \ No newline at end of file >>> +MODULE_DESCRIPTION("Test module for lockless object pool"); >>> +MODULE_LICENSE("GPL"); >>> >>> --- >>> base-commit: b050496579632f86ee1ef7e7501906db579f3457 >>> change-id: 20240531-md-lib-test_objpool-338d937f8666 >>> >> >> Looks good to me. Thanks for the update. >> >> I added Masami Hiramatsu and linux-trace in the loop. >> >> Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com> > > Thanks, let me pick this to probes/for-next branch. Following up since I don't see this in linux-next. I'm hoping to have these warnings fixed tree-wide in 6.11. /jeff ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro 2024-07-11 18:14 ` Jeff Johnson @ 2024-07-15 8:30 ` Masami Hiramatsu 2024-07-15 9:12 ` Masami Hiramatsu 1 sibling, 0 replies; 7+ messages in thread From: Masami Hiramatsu @ 2024-07-15 8:30 UTC (permalink / raw) To: Jeff Johnson Cc: wuqiang.matt, Andrew Morton, linux-kernel, kernel-janitors, linux-trace-kernel On Thu, 11 Jul 2024 11:14:20 -0700 Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > On 6/2/24 23:45, Masami Hiramatsu (Google) wrote: > > On Mon, 3 Jun 2024 11:25:59 +0800 > > "wuqiang.matt" <wuqiang.matt@bytedance.com> wrote: > > > >> On 2024/6/1 08:31, Jeff Johnson wrote: > >>> make allmodconfig && make W=1 C=1 reports: > >>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o > >>> > >>> Add the missing invocation of the MODULE_DESCRIPTION() macro. > >>> > >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > >>> --- > >>> lib/test_objpool.c | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/lib/test_objpool.c b/lib/test_objpool.c > >>> index bfdb81599832..5a3f6961a70f 100644 > >>> --- a/lib/test_objpool.c > >>> +++ b/lib/test_objpool.c > >>> @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void) > >>> module_init(ot_mod_init); > >>> module_exit(ot_mod_exit); > >>> > >>> -MODULE_LICENSE("GPL"); > >>> \ No newline at end of file > >>> +MODULE_DESCRIPTION("Test module for lockless object pool"); > >>> +MODULE_LICENSE("GPL"); > >>> > >>> --- > >>> base-commit: b050496579632f86ee1ef7e7501906db579f3457 > >>> change-id: 20240531-md-lib-test_objpool-338d937f8666 > >>> > >> > >> Looks good to me. Thanks for the update. > >> > >> I added Masami Hiramatsu and linux-trace in the loop. > >> > >> Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com> > > > > Thanks, let me pick this to probes/for-next branch. > Following up since I don't see this in linux-next. > I'm hoping to have these warnings fixed tree-wide in 6.11. Oops, sorry, I missed this. Let me try. Thank you, > > /jeff > -- Masami Hiramatsu (Google) <mhiramat@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro 2024-07-11 18:14 ` Jeff Johnson 2024-07-15 8:30 ` Masami Hiramatsu @ 2024-07-15 9:12 ` Masami Hiramatsu 2024-07-15 14:25 ` Jeff Johnson 2024-07-15 16:11 ` Jeff Johnson 1 sibling, 2 replies; 7+ messages in thread From: Masami Hiramatsu @ 2024-07-15 9:12 UTC (permalink / raw) To: Jeff Johnson Cc: wuqiang.matt, Andrew Morton, linux-kernel, kernel-janitors, linux-trace-kernel On Thu, 11 Jul 2024 11:14:20 -0700 Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > On 6/2/24 23:45, Masami Hiramatsu (Google) wrote: > > On Mon, 3 Jun 2024 11:25:59 +0800 > > "wuqiang.matt" <wuqiang.matt@bytedance.com> wrote: > > > >> On 2024/6/1 08:31, Jeff Johnson wrote: > >>> make allmodconfig && make W=1 C=1 reports: > >>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o > >>> > >>> Add the missing invocation of the MODULE_DESCRIPTION() macro. > >>> > >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > >>> --- > >>> lib/test_objpool.c | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/lib/test_objpool.c b/lib/test_objpool.c > >>> index bfdb81599832..5a3f6961a70f 100644 > >>> --- a/lib/test_objpool.c > >>> +++ b/lib/test_objpool.c > >>> @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void) > >>> module_init(ot_mod_init); > >>> module_exit(ot_mod_exit); > >>> > >>> -MODULE_LICENSE("GPL"); > >>> \ No newline at end of file > >>> +MODULE_DESCRIPTION("Test module for lockless object pool"); > >>> +MODULE_LICENSE("GPL"); > >>> > >>> --- > >>> base-commit: b050496579632f86ee1ef7e7501906db579f3457 > >>> change-id: 20240531-md-lib-test_objpool-338d937f8666 > >>> > >> > >> Looks good to me. Thanks for the update. > >> > >> I added Masami Hiramatsu and linux-trace in the loop. > >> > >> Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com> > > > > Thanks, let me pick this to probes/for-next branch. > Following up since I don't see this in linux-next. > I'm hoping to have these warnings fixed tree-wide in 6.11. > > /jeff > Can you resend it to me and linux-trace-kernel with Matt's Reviewed-by? Also, can you add the warning message? Thank you, -- Masami Hiramatsu (Google) <mhiramat@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro 2024-07-15 9:12 ` Masami Hiramatsu @ 2024-07-15 14:25 ` Jeff Johnson 2024-07-15 16:11 ` Jeff Johnson 1 sibling, 0 replies; 7+ messages in thread From: Jeff Johnson @ 2024-07-15 14:25 UTC (permalink / raw) To: Masami Hiramatsu (Google) Cc: wuqiang.matt, Andrew Morton, linux-kernel, kernel-janitors, linux-trace-kernel On 7/15/2024 2:12 AM, Masami Hiramatsu (Google) wrote: > On Thu, 11 Jul 2024 11:14:20 -0700 > Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > >> On 6/2/24 23:45, Masami Hiramatsu (Google) wrote: >>> On Mon, 3 Jun 2024 11:25:59 +0800 >>> "wuqiang.matt" <wuqiang.matt@bytedance.com> wrote: >>> >>>> On 2024/6/1 08:31, Jeff Johnson wrote: >>>>> make allmodconfig && make W=1 C=1 reports: >>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o >>>>> >>>>> Add the missing invocation of the MODULE_DESCRIPTION() macro. >>>>> >>>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >>>>> --- >>>>> lib/test_objpool.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/lib/test_objpool.c b/lib/test_objpool.c >>>>> index bfdb81599832..5a3f6961a70f 100644 >>>>> --- a/lib/test_objpool.c >>>>> +++ b/lib/test_objpool.c >>>>> @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void) >>>>> module_init(ot_mod_init); >>>>> module_exit(ot_mod_exit); >>>>> >>>>> -MODULE_LICENSE("GPL"); >>>>> \ No newline at end of file >>>>> +MODULE_DESCRIPTION("Test module for lockless object pool"); >>>>> +MODULE_LICENSE("GPL"); >>>>> >>>>> --- >>>>> base-commit: b050496579632f86ee1ef7e7501906db579f3457 >>>>> change-id: 20240531-md-lib-test_objpool-338d937f8666 >>>>> >>>> >>>> Looks good to me. Thanks for the update. >>>> >>>> I added Masami Hiramatsu and linux-trace in the loop. >>>> >>>> Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com> >>> >>> Thanks, let me pick this to probes/for-next branch. >> Following up since I don't see this in linux-next. >> I'm hoping to have these warnings fixed tree-wide in 6.11. >> >> /jeff >> > > Can you resend it to me and linux-trace-kernel with Matt's > Reviewed-by? Also, can you add the warning message? v2 sent. note the warning message was already there. /jeff ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro 2024-07-15 9:12 ` Masami Hiramatsu 2024-07-15 14:25 ` Jeff Johnson @ 2024-07-15 16:11 ` Jeff Johnson 1 sibling, 0 replies; 7+ messages in thread From: Jeff Johnson @ 2024-07-15 16:11 UTC (permalink / raw) To: Masami Hiramatsu (Google) Cc: wuqiang.matt, Andrew Morton, linux-kernel, kernel-janitors, linux-trace-kernel BTW I have another patch in arch/arm/probes/kprobes/test-kprobes.c Is that one you should handle? https://lore.kernel.org/all/20240622-md-arm-arch-arm-probes-kprobes-v1-1-0832bd6e45db@quicinc.com/ /jeff ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-15 16:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240531-md-lib-test_objpool-v1-1-516efee92a05@quicinc.com>
2024-06-03 3:25 ` [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro wuqiang.matt
2024-06-03 6:45 ` Masami Hiramatsu
2024-07-11 18:14 ` Jeff Johnson
2024-07-15 8:30 ` Masami Hiramatsu
2024-07-15 9:12 ` Masami Hiramatsu
2024-07-15 14:25 ` Jeff Johnson
2024-07-15 16:11 ` Jeff Johnson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).